Re: [PATCH 5/5] gdb: remove special case completion word handling for filenames

[Andrew Burgess <aburgess@redhat.com>]

Hannes Domani <ssbssa@yahoo.de> writes:

>  Am Mittwoch, 17. Januar 2024, 13:09:38 MEZ hat Eli Zaretskii <eliz@gnu.org> Folgendes geschrieben:
>
>> > From: Andrew Burgess <aburgess@redhat.com>
>>
>> > Cc: Andrew Burgess <aburgess@redhat.com>,
>> >     Eli Zaretskii <eliz@gnu.org>
>> > Date: Tue, 16 Jan 2024 21:24:02 +0000
>> >
>> > Eli,
>> >
>> > CC-ing you directly as the work I'm touching was originally done by
>> > you, see:
>> >
>> >  https://sourceware.org/pipermail/gdb-patches/2001-February/007313.html
>> >
>> > The original email mentions 4 cases:
>> >
>> >  - completion on a file name in a list of file names didn't work;
>> >  - GDB would not always append a slash if the completion is a directory;
>> >  - completion failed when the file name had non-file-name characters,
>> >    such as redirection, around it;
>> >  - on DOS/Windows, completion would fail with files with a drive letter.
>> >
>> > I believe I've tested the first 3 of these and they all seem to work
>> > fine still, but I don't have a working Windows machine on which I can
>> > test case #4.  I just wanted to bring this change to your attention in
>> > case you wanted to build/test this and check that completion around
>> > drive letters was still working as expected.
>>
>>
>> Thanks.  I won't have enough time for this soon enough, unfortunately.
>> Maybe someone else could do that?  I've taken the liberty of CC'ing
>> Hannes, in the hope that he could find some time for this soon.
>
>
> Not sure if this is exactly what you had in mind, but I tested
> a few things with the patches applied, and saw no problems.

Thanks for doing this.  I didn't think this would have broken anything,
but without a Windows machine to test on I'm always a little nervous
messing with this sort of code.  I feel better knowing that at least
I've not completely broken things :)

Thanks again,
Andrew

>
> Absolute path:
>
> (gdb) complete file c:/gdb/build64/gdb-git-python3/g
> file c:/gdb/build64/gdb-git-python3/gdb/
> file c:/gdb/build64/gdb-git-python3/gdbserver/
> file c:/gdb/build64/gdb-git-python3/gdbsupport/
> file c:/gdb/build64/gdb-git-python3/gnulib/
> (gdb) complete file "c:/gdb/build64/gdb-git-python3/g
> file "c:/gdb/build64/gdb-git-python3/gdb/"
> file "c:/gdb/build64/gdb-git-python3/gdbserver/"
> file "c:/gdb/build64/gdb-git-python3/gdbsupport/"
> file "c:/gdb/build64/gdb-git-python3/gnulib/"
>
> Absolute path on the same drive:
>
> (gdb) complete file /gdb/build64/gdb-git-python3/g
> file /gdb/build64/gdb-git-python3/gdb/
> file /gdb/build64/gdb-git-python3/gdbserver/
> file /gdb/build64/gdb-git-python3/gdbsupport/
> file /gdb/build64/gdb-git-python3/gnulib/
> (gdb) complete file "/gdb/build64/gdb-git-python3/g
> file "/gdb/build64/gdb-git-python3/gdb/"
> file "/gdb/build64/gdb-git-python3/gdbserver/"
> file "/gdb/build64/gdb-git-python3/gdbsupport/"
> file "/gdb/build64/gdb-git-python3/gnulib/"
>
> Relative path:
>
> (gdb) pwd
> Working directory C:\gdb\build64\gdb-git-python3.
> (gdb) complete file g
> file gdb/
> file gdbserver/
> file gdbsupport/
> file gnulib/
> (gdb) complete file "g
> file "gdb/"
> file "gdbserver/"
> file "gdbsupport/"
> file "gnulib/"
>
> And filename-completion.exp has no fails:
>
> Running /c/src/repos/binutils-gdb.git/gdb/testsuite/gdb.base/filename-completion.exp ...
>
>                 === gdb Summary ===
>
> # of expected passes            15