From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id BEC8HpHwqGW/eT8AWB0awg (envelope-from ) for ; Thu, 18 Jan 2024 04:34:09 -0500 Authentication-Results: simark.ca; dkim=pass (1024-bit key; unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256 header.s=mimecast20190719 header.b=jBZK0cLl; dkim-atps=neutral Received: by simark.ca (Postfix, from userid 112) id 756CD1E0C3; Thu, 18 Jan 2024 04:34:09 -0500 (EST) Received: from server2.sourceware.org (server2.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 5C0991E092 for ; Thu, 18 Jan 2024 04:34:07 -0500 (EST) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 39667385842D for ; Thu, 18 Jan 2024 09:34:06 +0000 (GMT) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by sourceware.org (Postfix) with ESMTPS id 217803858C41 for ; Thu, 18 Jan 2024 09:33:37 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 217803858C41 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=redhat.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 217803858C41 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=170.10.129.124 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1705570423; cv=none; b=MQ1WQiWCDnuHJVFyX+NjOITvEVCMzjC1Z/wxKTCgaZP/Li2KyVTS3swGeI/5b1yB5gXCtTcombs/dAe9Zp67tEN4fjdJ4Xfm1+oGm+b/yEw/Id+KGAdZXYlBBHMCBmrEYLL678QUfpsbzacPnTwiSq99bqKjeBwjeDCq2CtrpI0= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1705570423; c=relaxed/simple; bh=cBJLN2zy8AfxaYC1RibTy59D8Z1t1s26Nw8DYt4EWIE=; h=DKIM-Signature:From:To:Subject:Date:Message-ID:MIME-Version; b=WYlkO7ycibuZhgZ+b/rnxESkdPxXMYaEzqfrLSPcp/Gxn4fe21EEWbKGwEmWIhy5/z3NC4M7wsfUUrY/zrWJAPf6GN2THTZT6f2cTBLG14HrmParQnKSOnEOtlIA+h7XrtSyaw/IygjgvLaoLrDp3PMReBMCkZ2JOIzDm3OHjOU= ARC-Authentication-Results: i=1; server2.sourceware.org DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1705570416; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=+NaxvRMnOn12vvO8g9xEWo0Rg16tmpJRcmTiKvvixIQ=; b=jBZK0cLlddDCCzzuYK272vdEvo+I3q+SIicwvqoiiPX1ThA7rUAoj2JiCuRaecnkPOZqqp cxDwg/UVRzrEzWgqzE2IqgisHKF3r/9aLjjt+IQ64Zgaa1KBxgdvsVd6jPBlBYMmzu4Bc9 jGxxj7IkgQ1cfFTPNCHNEBn7ywL/mxM= Received: from mail-wm1-f72.google.com (mail-wm1-f72.google.com [209.85.128.72]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-571-hfRPLwaQMl2idTBascwXLg-1; Thu, 18 Jan 2024 04:33:33 -0500 X-MC-Unique: hfRPLwaQMl2idTBascwXLg-1 Received: by mail-wm1-f72.google.com with SMTP id 5b1f17b1804b1-40e46bceed8so84705605e9.0 for ; Thu, 18 Jan 2024 01:33:33 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1705570412; x=1706175212; h=content-transfer-encoding:mime-version:message-id:date:references :in-reply-to:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=+NaxvRMnOn12vvO8g9xEWo0Rg16tmpJRcmTiKvvixIQ=; b=kGzWfiAScIupgBQLiS94dFjOCnK6rNL9S+T8ZbSmD4yb9a+/wf1DtPkRh7+RZJJadH 1Sa2QdSwdJ/PvBobHS/ahhpnHf4/Spd3EIJIhD7DZwVvJXyPBpeDmXoAW+/QhxBhh/8n RQD3lh+6p17Cxt1Bs1XHbD90ApWFy+Ef8W2a0wE2NUEv65Zf5m+FuUQNSX4BYeDKHNCK eld6z87MOsocGhUfXxleNv4naBG5lFSYVn45pbelO0QHBV9vG45fTjeQZsekx9N2hL2L 7VPXg6yCEji1R8/Gl8olcOGR6xQYKlluiooLBNn0YccNiLE7SVjRMnm+XDFEjC7m73JO JEoA== X-Gm-Message-State: AOJu0Yz8R2ws6QxRFEC5wAAX1tP/wYxAOg1Phans2cN1EjMrRmoto1Hf UM25CgISXD8jRCUL3hp2XmzJtZIlMrvC3XHDnyCkOCOvNkfQ1V/fqfY/2hQULs3npbT+5MYscxM rKLWP00ytP3pFGT5otayZzeVfEBnEpsMpsdPKRuR2rAYi7KHcZSTE3UmzMUw= X-Received: by 2002:a7b:c447:0:b0:40e:7b8c:20d2 with SMTP id l7-20020a7bc447000000b0040e7b8c20d2mr299414wmi.188.1705570412484; Thu, 18 Jan 2024 01:33:32 -0800 (PST) X-Google-Smtp-Source: AGHT+IGsJGBJJ2mL9nLiaW1YNTVcE8LSG0svfzhz7+u9IXKj/W4BC37enXKiQvJ/ZegHM0JogcGnmA== X-Received: by 2002:a7b:c447:0:b0:40e:7b8c:20d2 with SMTP id l7-20020a7bc447000000b0040e7b8c20d2mr299408wmi.188.1705570412161; Thu, 18 Jan 2024 01:33:32 -0800 (PST) Received: from localhost (185.223.159.143.dyn.plus.net. [143.159.223.185]) by smtp.gmail.com with ESMTPSA id v21-20020a05600c445500b0040e3bdff98asm28735363wmn.23.2024.01.18.01.33.31 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 18 Jan 2024 01:33:31 -0800 (PST) From: Andrew Burgess To: Hannes Domani , Eli Zaretskii Cc: "gdb-patches@sourceware.org" Subject: Re: [PATCH 5/5] gdb: remove special case completion word handling for filenames In-Reply-To: <1145412853.4584703.1705508979580@mail.yahoo.com> References: <048fa74bfb249273becb517d9edc9fd7a129e205.1705439706.git.aburgess@redhat.com> <83mst4b1qf.fsf@gnu.org> <1145412853.4584703.1705508979580@mail.yahoo.com> Date: Thu, 18 Jan 2024 09:33:31 +0000 Message-ID: <87v87r56l0.fsf@redhat.com> MIME-Version: 1.0 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Status: No, score=-5.5 required=5.0 tests=BAYES_00, BODY_8BITS, DKIMWL_WL_HIGH, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H4, RCVD_IN_MSPIKE_WL, SPF_HELO_NONE, SPF_NONE, TXREP, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces+public-inbox=simark.ca@sourceware.org Hannes Domani writes: > Am Mittwoch, 17. Januar 2024, 13:09:38 MEZ hat Eli Zaretskii Folgendes geschrieben: > >> > From: Andrew Burgess >> >> > Cc: Andrew Burgess , >> >=C2=A0=C2=A0=C2=A0=C2=A0 Eli Zaretskii >> > Date: Tue, 16 Jan 2024 21:24:02 +0000 >> > >> > Eli, >> > >> > CC-ing you directly as the work I'm touching was originally done by >> > you, see: >> > >> >=C2=A0 https://sourceware.org/pipermail/gdb-patches/2001-February/00731= 3.html >> > >> > The original email mentions 4 cases: >> > >> >=C2=A0 - completion on a file name in a list of file names didn't work; >> >=C2=A0 - GDB would not always append a slash if the completion is a dir= ectory; >> >=C2=A0 - completion failed when the file name had non-file-name charact= ers, >> >=C2=A0=C2=A0=C2=A0 such as redirection, around it; >> >=C2=A0 - on DOS/Windows, completion would fail with files with a drive = letter. >> > >> > I believe I've tested the first 3 of these and they all seem to work >> > fine still, but I don't have a working Windows machine on which I can >> > test case #4.=C2=A0 I just wanted to bring this change to your attenti= on in >> > case you wanted to build/test this and check that completion around >> > drive letters was still working as expected. >> >> >> Thanks.=C2=A0 I won't have enough time for this soon enough, unfortunate= ly. >> Maybe someone else could do that?=C2=A0 I've taken the liberty of CC'ing >> Hannes, in the hope that he could find some time for this soon. > > > Not sure if this is exactly what you had in mind, but I tested > a few things with the patches applied, and saw no problems. Thanks for doing this. I didn't think this would have broken anything, but without a Windows machine to test on I'm always a little nervous messing with this sort of code. I feel better knowing that at least I've not completely broken things :) Thanks again, Andrew > > Absolute path: > > (gdb) complete file c:/gdb/build64/gdb-git-python3/g > file c:/gdb/build64/gdb-git-python3/gdb/ > file c:/gdb/build64/gdb-git-python3/gdbserver/ > file c:/gdb/build64/gdb-git-python3/gdbsupport/ > file c:/gdb/build64/gdb-git-python3/gnulib/ > (gdb) complete file "c:/gdb/build64/gdb-git-python3/g > file "c:/gdb/build64/gdb-git-python3/gdb/" > file "c:/gdb/build64/gdb-git-python3/gdbserver/" > file "c:/gdb/build64/gdb-git-python3/gdbsupport/" > file "c:/gdb/build64/gdb-git-python3/gnulib/" > > Absolute path on the same drive: > > (gdb) complete file /gdb/build64/gdb-git-python3/g > file /gdb/build64/gdb-git-python3/gdb/ > file /gdb/build64/gdb-git-python3/gdbserver/ > file /gdb/build64/gdb-git-python3/gdbsupport/ > file /gdb/build64/gdb-git-python3/gnulib/ > (gdb) complete file "/gdb/build64/gdb-git-python3/g > file "/gdb/build64/gdb-git-python3/gdb/" > file "/gdb/build64/gdb-git-python3/gdbserver/" > file "/gdb/build64/gdb-git-python3/gdbsupport/" > file "/gdb/build64/gdb-git-python3/gnulib/" > > Relative path: > > (gdb) pwd > Working directory C:\gdb\build64\gdb-git-python3. > (gdb) complete file g > file gdb/ > file gdbserver/ > file gdbsupport/ > file gnulib/ > (gdb) complete file "g > file "gdb/" > file "gdbserver/" > file "gdbsupport/" > file "gnulib/" > > And filename-completion.exp has no fails: > > Running /c/src/repos/binutils-gdb.git/gdb/testsuite/gdb.base/filename-com= pletion.exp ... > > =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0= =C2=A0=C2=A0=C2=A0 =3D=3D=3D gdb Summary =3D=3D=3D > > # of expected passes=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2= =A0=C2=A0=C2=A0 15