Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Tom Tromey <tromey@redhat.com>
To: Yao Qi <yao@codesourcery.com>
Cc: <gdb-patches@sourceware.org>
Subject: Re: [PATCH 3/3] Remove varobj_language_string, languages and varobj_languages
Date: Mon, 28 Oct 2013 18:52:00 -0000	[thread overview]
Message-ID: <87txg1b54j.fsf@fleche.redhat.com> (raw)
In-Reply-To: <1382964489-24307-3-git-send-email-yao@codesourcery.com> (Yao	Qi's message of "Mon, 28 Oct 2013 20:48:09 +0800")

>>>>> "Yao" == Yao Qi <yao@codesourcery.com> writes:

Yao> This patch does some cleanups, removing some language-related stuff.
Yao> Note that mi_cmd_var_info_expression uses varobj_language_string,
Yao> which is redundant, because we can get language name from
Yao> lang-> la_natural_name.

Yao> varobj_language_string doesn't have "Ada", which looks like a bug to
Yao> me.  With this patch applied, this problem doesn't exist, because the
Yao> language name is got from the same place (field la_natural_name).

I think this is an improvement, and I'm inclined to approve it.
However, two thoughts.

First, it can change the language reported by varobj commands.
Does this matter?

Second, the MI docs have a list of languages that can be reported:

    Here, the values of @code{lang} can be @code{@{"C" | "C++" | "Java"@}}.

I think this needs to be updated.

Tom


  reply	other threads:[~2013-10-28 18:52 UTC|newest]

Thread overview: 21+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-10-18  0:54 [PATCH 1/2] New field la_varobj_ops in struct language_defn Yao Qi
2013-10-18  0:54 ` [PATCH 2/2] Remove varobj_language_string, languages and varobj_languages Yao Qi
2013-10-25  4:15   ` Joel Brobecker
2013-10-25 13:38     ` Yao Qi
2013-10-26  4:09       ` Joel Brobecker
2013-10-28 12:50     ` [PATCH 1/3] Constify 'la_name' in struct language_defn Yao Qi
2013-10-28 12:50       ` [PATCH 3/3] Remove varobj_language_string, languages and varobj_languages Yao Qi
2013-10-28 18:52         ` Tom Tromey [this message]
2013-10-29  8:33           ` Yao Qi
2013-10-29 16:49             ` Eli Zaretskii
2013-10-31  3:10               ` Yao Qi
2013-10-31 17:31                 ` Eli Zaretskii
2013-11-07  7:23               ` Yao Qi
2013-10-28 12:50       ` [PATCH 2/3] New field 'la_natural_name' in struct language_defn Yao Qi
2013-10-28 18:34         ` Tom Tromey
2013-10-29  8:41         ` Yao Qi
2013-11-07  7:18           ` Yao Qi
2013-10-28 15:02       ` [PATCH 1/3] Constify 'la_name' " Tom Tromey
2013-10-25  3:34 ` [PATCH 1/2] New field la_varobj_ops " Joel Brobecker
2013-10-25 13:16   ` Yao Qi
2013-10-27 12:04   ` Rename field 'lang' to 'lang_ops' ([PATCH 1/2] New field la_varobj_ops in struct language_defn) Yao Qi

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87txg1b54j.fsf@fleche.redhat.com \
    --to=tromey@redhat.com \
    --cc=gdb-patches@sourceware.org \
    --cc=yao@codesourcery.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox