From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 21843 invoked by alias); 28 Oct 2013 18:52:01 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 21832 invoked by uid 89); 28 Oct 2013 18:52:00 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-3.6 required=5.0 tests=AWL,BAYES_00,RP_MATCHES_RCVD,SPF_HELO_PASS,SPF_PASS autolearn=ham version=3.3.2 X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Mon, 28 Oct 2013 18:52:00 +0000 Received: from int-mx10.intmail.prod.int.phx2.redhat.com (int-mx10.intmail.prod.int.phx2.redhat.com [10.5.11.23]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id r9SIpvtb014730 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Mon, 28 Oct 2013 14:51:58 -0400 Received: from barimba (ovpn-113-94.phx2.redhat.com [10.3.113.94]) by int-mx10.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id r9SIpu6X023458 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES128-SHA bits=128 verify=NO); Mon, 28 Oct 2013 14:51:56 -0400 From: Tom Tromey To: Yao Qi Cc: Subject: Re: [PATCH 3/3] Remove varobj_language_string, languages and varobj_languages References: <20131025041525.GC4769@adacore.com> <1382964489-24307-1-git-send-email-yao@codesourcery.com> <1382964489-24307-3-git-send-email-yao@codesourcery.com> Date: Mon, 28 Oct 2013 18:52:00 -0000 In-Reply-To: <1382964489-24307-3-git-send-email-yao@codesourcery.com> (Yao Qi's message of "Mon, 28 Oct 2013 20:48:09 +0800") Message-ID: <87txg1b54j.fsf@fleche.redhat.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.3 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-SW-Source: 2013-10/txt/msg00877.txt.bz2 >>>>> "Yao" == Yao Qi writes: Yao> This patch does some cleanups, removing some language-related stuff. Yao> Note that mi_cmd_var_info_expression uses varobj_language_string, Yao> which is redundant, because we can get language name from Yao> lang-> la_natural_name. Yao> varobj_language_string doesn't have "Ada", which looks like a bug to Yao> me. With this patch applied, this problem doesn't exist, because the Yao> language name is got from the same place (field la_natural_name). I think this is an improvement, and I'm inclined to approve it. However, two thoughts. First, it can change the language reported by varobj commands. Does this matter? Second, the MI docs have a list of languages that can be reported: Here, the values of @code{lang} can be @code{@{"C" | "C++" | "Java"@}}. I think this needs to be updated. Tom