From: Tom Tromey <tom@tromey.com>
To: Simon Marchi <simark@simark.ca>
Cc: Andrew Burgess <andrew.burgess@embecosm.com>,
gdb-patches@sourceware.org, jimw@sifive.com,
palmer@sifive.com, jhb@FreeBSD.org
Subject: Re: [PATCH] gdb: Allow struct fields named double
Date: Sun, 16 Dec 2018 16:42:00 -0000 [thread overview]
Message-ID: <87tvjd4e54.fsf@tromey.com> (raw)
In-Reply-To: <98105817-ba16-27f9-5bcb-7a6e7555f87b@simark.ca> (Simon Marchi's message of "Sun, 16 Dec 2018 11:23:33 -0500")
>>>>> "Simon" == Simon Marchi <simark@simark.ca> writes:
Simon> This looks reasonable to me, from the user point of view there is not reason
Simon> why x.double would be different from x.float. With the same logic, we should
Simon> also allow x.int, x.short, etc. But I'm fine with doing it on an as-needed basis.
See also https://sourceware.org/bugzilla/show_bug.cgi?id=13368
Simon> This LGTM, with one thing below you might want to change. I'm far from an expert
Simon> in parsers though, so please give others ~1 week to comment, and push then if you
Simon> don't receive additional feedback.
I think the main possible issue is if this introduces a new parser conflict.
Taking a glance at the uses of "name" in the grammar, though, it seems
safe enough.
Tom
next prev parent reply other threads:[~2018-12-16 16:42 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-12-15 23:25 Andrew Burgess
2018-12-16 16:23 ` Simon Marchi
2018-12-16 16:42 ` Tom Tromey [this message]
2018-12-18 22:40 ` [PATCHv2 1/4] gdb: Extend the comments in c-exp.y Andrew Burgess
2018-12-21 15:44 ` Tom Tromey
2018-12-18 22:40 ` [PATCHv2 0/4] gdb: Allow struct fields named double Andrew Burgess
2018-12-24 17:30 ` Andrew Burgess
2018-12-18 22:40 ` [PATCHv2 3/4] gdb: Add new parser rule for structure field names Andrew Burgess
2018-12-21 16:38 ` Tom Tromey
2018-12-18 22:40 ` [PATCHv2 4/4] gdb: Allow struct fields named double Andrew Burgess
2018-12-21 17:19 ` Tom Tromey
2018-12-18 22:40 ` [PATCHv2 2/4] gdb: Resolve 49 reduce/reduce conflicts in c-exp.y Andrew Burgess
2018-12-21 16:37 ` Tom Tromey
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87tvjd4e54.fsf@tromey.com \
--to=tom@tromey.com \
--cc=andrew.burgess@embecosm.com \
--cc=gdb-patches@sourceware.org \
--cc=jhb@FreeBSD.org \
--cc=jimw@sifive.com \
--cc=palmer@sifive.com \
--cc=simark@simark.ca \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox