From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 101804 invoked by alias); 16 Dec 2018 16:42:22 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 101790 invoked by uid 89); 16 Dec 2018 16:42:21 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-1.9 required=5.0 tests=BAYES_00,RCVD_IN_DNSWL_NONE,SPF_HELO_PASS autolearn=ham version=3.3.2 spammy=Hx-languages-length:817, grammar X-HELO: gateway33.websitewelcome.com Received: from gateway33.websitewelcome.com (HELO gateway33.websitewelcome.com) (192.185.146.21) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Sun, 16 Dec 2018 16:42:20 +0000 Received: from cm12.websitewelcome.com (cm12.websitewelcome.com [100.42.49.8]) by gateway33.websitewelcome.com (Postfix) with ESMTP id B663E10798B for ; Sun, 16 Dec 2018 10:42:16 -0600 (CST) Received: from box5379.bluehost.com ([162.241.216.53]) by cmsmtp with SMTP id YZUegZz3CiQerYZUegg3Zf; Sun, 16 Dec 2018 10:42:16 -0600 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=tromey.com; s=default; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date: References:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=NTTYCEs28qR23jFAmO3pP5k7vyfO1B7IAfnx/VwEB+E=; b=OROIGiDFpQw8thC0TDJtQiOVcH 3FEymfpW1fvdT4UhOyT6eInWwIvpR4XJJwBRzL0zI/wGmjlVj5lqTvQThDHXuvWvvlO8Je9yeMmJ/ wE5O/ZQ3DUmbG5P/DVJLSAI8U; Received: from 75-166-72-210.hlrn.qwest.net ([75.166.72.210]:46272 helo=bapiya) by box5379.bluehost.com with esmtpsa (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.91) (envelope-from ) id 1gYZUe-000MMH-4X; Sun, 16 Dec 2018 10:42:16 -0600 From: Tom Tromey To: Simon Marchi Cc: Andrew Burgess , gdb-patches@sourceware.org, jimw@sifive.com, palmer@sifive.com, jhb@FreeBSD.org Subject: Re: [PATCH] gdb: Allow struct fields named double References: <20181215232414.10883-1-andrew.burgess@embecosm.com> <98105817-ba16-27f9-5bcb-7a6e7555f87b@simark.ca> Date: Sun, 16 Dec 2018 16:42:00 -0000 In-Reply-To: <98105817-ba16-27f9-5bcb-7a6e7555f87b@simark.ca> (Simon Marchi's message of "Sun, 16 Dec 2018 11:23:33 -0500") Message-ID: <87tvjd4e54.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.1.90 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-SW-Source: 2018-12/txt/msg00185.txt.bz2 >>>>> "Simon" == Simon Marchi writes: Simon> This looks reasonable to me, from the user point of view there is not reason Simon> why x.double would be different from x.float. With the same logic, we should Simon> also allow x.int, x.short, etc. But I'm fine with doing it on an as-needed basis. See also https://sourceware.org/bugzilla/show_bug.cgi?id=13368 Simon> This LGTM, with one thing below you might want to change. I'm far from an expert Simon> in parsers though, so please give others ~1 week to comment, and push then if you Simon> don't receive additional feedback. I think the main possible issue is if this introduces a new parser conflict. Taking a glance at the uses of "name" in the grammar, though, it seems safe enough. Tom