From: Sergio Durigan Junior <sergiodj@redhat.com>
To: Tom Tromey <tom@tromey.com>
Cc: Andreas Schwab <schwab@suse.de>,
GDB Patches <gdb-patches@sourceware.org>
Subject: Re: [PATCH] Don't crash if dwarf_decode_macro_bytes's 'body' is NULL
Date: Wed, 15 May 2019 13:59:00 -0000 [thread overview]
Message-ID: <87tvdv3jjy.fsf@redhat.com> (raw)
In-Reply-To: <877ear7rk7.fsf@tromey.com> (Tom Tromey's message of "Wed, 15 May 2019 07:52:56 -0600")
On Wednesday, May 15 2019, Tom Tromey wrote:
>>>>>> "Andreas" == Andreas Schwab <schwab@suse.de> writes:
>
> Andreas> On Mai 14 2019, Sergio Durigan Junior <sergiodj@redhat.com> wrote:
>>> complaint (_("debug info gives %s invalid macro definition "
>>> "without body (corrupted?) at line %d"
>>> "on file %s"),
>>> at_commandline ? _("command-line")
>>> : _("in-file"),
>>> line, current_file->filename);
>
> Andreas> Note that this is difficult to translate.
>
> True. However, there are other similar ones nearby; and it is just a
> complaint (turned off by default); and nobody seems very serious about
> translating gdb anyhow -- there are no translations in-tree.
Thanks; I was going to point out that there are several other strings
that are hard to translate in the file.
I pushed the patch now, thank you.
7bede82892a06e6c26989803e70f53697392dcf9
--
Sergio
GPG key ID: 237A 54B1 0287 28BF 00EF 31F4 D0EB 7628 65FC 5E36
Please send encrypted e-mail if possible
http://sergiodj.net/
next prev parent reply other threads:[~2019-05-15 13:59 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-05-10 21:04 [PATCH] Don't crash if parse_definition_macro's " Sergio Durigan Junior
2019-05-13 14:01 ` Tom Tromey
2019-05-14 20:54 ` Sergio Durigan Junior
2019-05-14 20:55 ` [PATCH] Don't crash if dwarf_decode_macro_bytes's " Sergio Durigan Junior
2019-05-14 22:10 ` Tom Tromey
2019-05-14 23:36 ` Sergio Durigan Junior
2019-05-15 1:38 ` Tom Tromey
2019-05-15 8:49 ` Andreas Schwab
2019-05-15 13:53 ` Tom Tromey
2019-05-15 13:59 ` Sergio Durigan Junior [this message]
2019-05-29 14:43 ` [PATCH] Don't crash is dwarf_decode_macro_bytes's 'body' is NULL, even when '!is_define' Sergio Durigan Junior
2019-05-29 15:55 ` Tom Tromey
2019-05-29 20:16 ` Sergio Durigan Junior
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87tvdv3jjy.fsf@redhat.com \
--to=sergiodj@redhat.com \
--cc=gdb-patches@sourceware.org \
--cc=schwab@suse.de \
--cc=tom@tromey.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox