From: Sergio Durigan Junior <sergiodj@redhat.com>
To: Tom Tromey <tromey@adacore.com>
Cc: GDB Patches <gdb-patches@sourceware.org>
Subject: Re: [PATCH] Don't crash is dwarf_decode_macro_bytes's 'body' is NULL, even when '!is_define'
Date: Wed, 29 May 2019 20:16:00 -0000 [thread overview]
Message-ID: <87tvdddnk8.fsf@redhat.com> (raw)
In-Reply-To: <877ea9z24k.fsf@tromey.com> (Tom Tromey's message of "Wed, 29 May 2019 09:55:39 -0600")
On Wednesday, May 29 2019, Tom Tromey wrote:
>>>>>> "Sergio" == Sergio Durigan Junior <sergiodj@redhat.com> writes:
>
> Sergio> Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1715008
> Sergio> On commit 7bede82892a06e6c26989803e70f53697392dcf9 ("Don't crash if
> Sergio> dwarf_decode_macro_bytes's 'body' is NULL"), I was too strict when
> Sergio> checking if 'body' is NULL: the check only comprised the case when
> Sergio> 'is_define' is true. However, the corruption of .debug_macro by
> Sergio> rpmbuild's "debugedit" also affects the case when 'is_define' is
> Sergio> false, i.e., when the macro is being undefined.
>
> Sergio> This commit improves the check and covers both cases now. This has
> Sergio> been tested on Fedora 30 with a problematic debuginfo, and I don't see
> Sergio> a segfault anymore.
>
> Sergio> OK to push?
>
> Thanks for doing this. This is ok.
Thanks for the review, Tom.
Pushed: 955b06fa576df1a6954263043ea3f3a5b9ad5940
--
Sergio
GPG key ID: 237A 54B1 0287 28BF 00EF 31F4 D0EB 7628 65FC 5E36
Please send encrypted e-mail if possible
http://sergiodj.net/
prev parent reply other threads:[~2019-05-29 20:16 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-05-10 21:04 [PATCH] Don't crash if parse_definition_macro's 'body' is NULL Sergio Durigan Junior
2019-05-13 14:01 ` Tom Tromey
2019-05-14 20:54 ` Sergio Durigan Junior
2019-05-14 20:55 ` [PATCH] Don't crash if dwarf_decode_macro_bytes's " Sergio Durigan Junior
2019-05-14 22:10 ` Tom Tromey
2019-05-14 23:36 ` Sergio Durigan Junior
2019-05-15 1:38 ` Tom Tromey
2019-05-15 8:49 ` Andreas Schwab
2019-05-15 13:53 ` Tom Tromey
2019-05-15 13:59 ` Sergio Durigan Junior
2019-05-29 14:43 ` [PATCH] Don't crash is dwarf_decode_macro_bytes's 'body' is NULL, even when '!is_define' Sergio Durigan Junior
2019-05-29 15:55 ` Tom Tromey
2019-05-29 20:16 ` Sergio Durigan Junior [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87tvdddnk8.fsf@redhat.com \
--to=sergiodj@redhat.com \
--cc=gdb-patches@sourceware.org \
--cc=tromey@adacore.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox