Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Tom Tromey <tom@tromey.com>
To: Tom de Vries via Gdb-patches <gdb-patches@sourceware.org>
Subject: Re: [PATCH][gdb/testsuite] Reimplement complaints selftest as unittest
Date: Wed, 08 Sep 2021 13:02:26 -0600	[thread overview]
Message-ID: <87tuiuj3gd.fsf@tromey.com> (raw)
In-Reply-To: <b29f5118-1131-e2a6-1384-9ac0451f4643@suse.de> (Tom de Vries via Gdb-patches's message of "Fri, 3 Sep 2021 13:18:57 +0200")

>>>>> "Tom" == Tom de Vries via Gdb-patches <gdb-patches@sourceware.org> writes:

Tom> On 9/2/21 3:42 PM, Tom de Vries wrote:
>> Something specific to the new unittest is that we check the output as well.
>> To this end, we add SELFTEST_OUTPUT and SELFTEST_EXPECTED_OUTPUT markers:

Tom> I tried it in another way: capturing the output, which means there's no
Tom> need for the testsuite to verify the output.

I was planning to suggest something like this :)

Tom> Passes build & gdb.gdb/unittest.exp, currently doing full regression
Tom> test run.

Tom> Any comments?

I like this approach.  Thank you for doing this.

Tom

      reply	other threads:[~2021-09-08 19:02 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-09-02 13:42 Tom de Vries via Gdb-patches
2021-09-03 11:18 ` Tom de Vries via Gdb-patches
2021-09-08 19:02   ` Tom Tromey [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87tuiuj3gd.fsf@tromey.com \
    --to=tom@tromey.com \
    --cc=gdb-patches@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox