From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id AXmGDdIIOWGSZQAAWB0awg (envelope-from ) for ; Wed, 08 Sep 2021 15:02:42 -0400 Received: by simark.ca (Postfix, from userid 112) id 1E42B1EE23; Wed, 8 Sep 2021 15:02:42 -0400 (EDT) X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-0.4 required=5.0 tests=DKIM_INVALID,DKIM_SIGNED, MAILING_LIST_MULTI,RDNS_DYNAMIC,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.2 Received: from sourceware.org (ip-8-43-85-97.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 6B15B1ECEB for ; Wed, 8 Sep 2021 15:02:41 -0400 (EDT) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 153EB3864810 for ; Wed, 8 Sep 2021 19:02:41 +0000 (GMT) Received: from gateway32.websitewelcome.com (gateway32.websitewelcome.com [192.185.145.187]) by sourceware.org (Postfix) with ESMTPS id BBE3E3858414 for ; Wed, 8 Sep 2021 19:02:28 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org BBE3E3858414 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=tromey.com Authentication-Results: sourceware.org; spf=fail smtp.mailfrom=tromey.com Received: from cm10.websitewelcome.com (cm10.websitewelcome.com [100.42.49.4]) by gateway32.websitewelcome.com (Postfix) with ESMTP id 526D15672B for ; Wed, 8 Sep 2021 14:02:28 -0500 (CDT) Received: from box5379.bluehost.com ([162.241.216.53]) by cmsmtp with SMTP id O2q3mE7H7HlR1O2q4mdo38; Wed, 08 Sep 2021 14:02:28 -0500 X-Authority-Reason: nr=8 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=tromey.com; s=default; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date:References :Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=UpLuSjJesR5RqzbCdRw5qG9m4EJXZZdKpbDP5mvcoKE=; b=NpnaQYMVABj6RfG9sNeNDhwBBj qbNum/TQ32mhe/jvodDdnGQuMIlruKcQNv8N0ka1H4JiTRURlaxVeL/3Y04ZgN4XwmN83f1Qizbwm wF48tBYeQCubXuXnReLZr2ovC; Received: from 97-122-72-212.hlrn.qwest.net ([97.122.72.212]:40760 helo=murgatroyd) by box5379.bluehost.com with esmtpsa (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1mO2q3-001ic6-CI; Wed, 08 Sep 2021 13:02:27 -0600 From: Tom Tromey To: Tom de Vries via Gdb-patches Subject: Re: [PATCH][gdb/testsuite] Reimplement complaints selftest as unittest References: <20210902134249.GA25158@delia> X-Attribution: Tom Date: Wed, 08 Sep 2021 13:02:26 -0600 In-Reply-To: (Tom de Vries via Gdb-patches's message of "Fri, 3 Sep 2021 13:18:57 +0200") Message-ID: <87tuiuj3gd.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - box5379.bluehost.com X-AntiAbuse: Original Domain - sourceware.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - tromey.com X-BWhitelist: no X-Source-IP: 97.122.72.212 X-Source-L: No X-Exim-ID: 1mO2q3-001ic6-CI X-Source: X-Source-Args: X-Source-Dir: X-Source-Sender: 97-122-72-212.hlrn.qwest.net (murgatroyd) [97.122.72.212]:40760 X-Source-Auth: tom+tromey.com X-Email-Count: 1 X-Source-Cap: ZWx5bnJvYmk7ZWx5bnJvYmk7Ym94NTM3OS5ibHVlaG9zdC5jb20= X-Local-Domain: yes X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces+public-inbox=simark.ca@sourceware.org Sender: "Gdb-patches" >>>>> "Tom" == Tom de Vries via Gdb-patches writes: Tom> On 9/2/21 3:42 PM, Tom de Vries wrote: >> Something specific to the new unittest is that we check the output as well. >> To this end, we add SELFTEST_OUTPUT and SELFTEST_EXPECTED_OUTPUT markers: Tom> I tried it in another way: capturing the output, which means there's no Tom> need for the testsuite to verify the output. I was planning to suggest something like this :) Tom> Passes build & gdb.gdb/unittest.exp, currently doing full regression Tom> test run. Tom> Any comments? I like this approach. Thank you for doing this. Tom