Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Tom Tromey <tom@tromey.com>
To: Tom de Vries <tdevries@suse.de>
Cc: gdb-patches@sourceware.org
Subject: Re: [PATCH] [gdb/tui] Fix centering and highlighting of current line
Date: Mon, 01 Apr 2024 10:13:31 -0600	[thread overview]
Message-ID: <87ttkl9i38.fsf@tromey.com> (raw)
In-Reply-To: <20240328143313.24460-1-tdevries@suse.de> (Tom de Vries's message of "Thu, 28 Mar 2024 15:33:13 +0100")

>>>>> "Tom" == Tom de Vries <tdevries@suse.de> writes:

Tom> Fix these problems respectively by:
Tom> - in tui_enable, instead of "tui_show_frame_info (0)" using
Tom>   'tui_show_frame_info (deprecated_safe_get_selected_frame ())", and
Tom> - in tui_source_window_base::rerender, adding centering functionality.

Thanks.
Approved-By: Tom Tromey <tom@tromey.com>

Tom> +      /* This centering code is copied from tui_source_window::maybe_update.
Tom> +	 It would be nice to do centering more often, and do it in just one
Tom> +	 location.  But since this is a regression fix, handle this
Tom> +	 conservatively for now.  */

Yeah, unfortunately some of this code remains spaghetti from the old
days.

Tom

      parent reply	other threads:[~2024-04-01 16:13 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-03-28 14:33 Tom de Vries
2024-03-28 16:38 ` Pedro Alves
2024-04-01 16:13 ` Tom Tromey [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87ttkl9i38.fsf@tromey.com \
    --to=tom@tromey.com \
    --cc=gdb-patches@sourceware.org \
    --cc=tdevries@suse.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox