From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id CECTLULdCmarFR8AWB0awg (envelope-from ) for ; Mon, 01 Apr 2024 12:13:54 -0400 Authentication-Results: simark.ca; dkim=fail reason="signature verification failed" (768-bit key; unprotected) header.d=tromey.com header.i=@tromey.com header.a=rsa-sha256 header.s=default header.b=SXY3R5FE; dkim-atps=neutral Received: by simark.ca (Postfix, from userid 112) id A84C91E0C0; Mon, 1 Apr 2024 12:13:54 -0400 (EDT) Received: from server2.sourceware.org (server2.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 8F7F11E030 for ; Mon, 1 Apr 2024 12:13:52 -0400 (EDT) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 201D83858404 for ; Mon, 1 Apr 2024 16:13:52 +0000 (GMT) Received: from omta40.uswest2.a.cloudfilter.net (omta40.uswest2.a.cloudfilter.net [35.89.44.39]) by sourceware.org (Postfix) with ESMTPS id 359B03858D20 for ; Mon, 1 Apr 2024 16:13:34 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 359B03858D20 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=tromey.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=tromey.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 359B03858D20 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=35.89.44.39 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1711988016; cv=none; b=AuMTdOfe3cInPvIi7RtezEL5QkvHn7yUqOsCuWd8QQSdDSEvKFHq4+6EX9fkoTBiPTOmryXAAcJhiPcQCHAcrvYm7V24WvwgKxj75CHT7gN/TnfZ/xsYb/Ra4VH5V+GT6M/79wKeNdI536rXbkV2bL3Sfm5pXFKsFp/02a2AtwI= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1711988016; c=relaxed/simple; bh=x4IMDT8fZzwUqtpiwNXHoirvnPeBOiuLnAhVZVQaI4c=; h=DKIM-Signature:From:To:Subject:Date:Message-ID:MIME-Version; b=LgBssAMXh1851qfgp2NPbW/nBB5yCA9UEk33p9jD7kOlFonXBCixEcQJxFIahZqKJJASnNqqBb6WHEylJ+xpd+eV9Rr8MTlW7fwR581Texufg8AdeWA/4hvORmC1ERgfdqPfKhKH4GQTkn7WPsQO3ojlYnLfJdEl9pHnnQomKW8= ARC-Authentication-Results: i=1; server2.sourceware.org Received: from eig-obgw-5004a.ext.cloudfilter.net ([10.0.29.221]) by cmsmtp with ESMTPS id rJpPr2wgMPM1hrKHtrc54F; Mon, 01 Apr 2024 16:13:33 +0000 Received: from box5379.bluehost.com ([162.241.216.53]) by cmsmtp with ESMTPS id rKHsrCuU1GDo0rKHsrEAMB; Mon, 01 Apr 2024 16:13:32 +0000 X-Authority-Analysis: v=2.4 cv=I+uuR8gg c=1 sm=1 tr=0 ts=660add2c a=ApxJNpeYhEAb1aAlGBBbmA==:117 a=ApxJNpeYhEAb1aAlGBBbmA==:17 a=raytVjVEu-sA:10 a=Qbun_eYptAEA:10 a=zstS-IiYAAAA:8 a=LQHqBGs78LU58MGq8pcA:9 a=4G6NA9xxw8l3yy4pmD5M:22 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=tromey.com; s=default; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date:References :Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=UwBk9UV0hnIk7v0grXSHEnvl2aJux9e+Q8i2H0Mgec8=; b=SXY3R5FEbBV4phnzKJl5WIGOgB 08spq5jBKjpP2nfacHtrhPkOAtMiEorpIqSs00PRywO362E2FWzCKZfKAy+FhA2sJrn14LoAQtTdd i7L1Q/OiybFOUccXg83SDraro; Received: from 97-122-82-115.hlrn.qwest.net ([97.122.82.115]:42890 helo=murgatroyd) by box5379.bluehost.com with esmtpsa (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.96.2) (envelope-from ) id 1rrKHr-001Z0u-2W; Mon, 01 Apr 2024 10:13:31 -0600 From: Tom Tromey To: Tom de Vries Cc: gdb-patches@sourceware.org Subject: Re: [PATCH] [gdb/tui] Fix centering and highlighting of current line References: <20240328143313.24460-1-tdevries@suse.de> X-Attribution: Tom Date: Mon, 01 Apr 2024 10:13:31 -0600 In-Reply-To: <20240328143313.24460-1-tdevries@suse.de> (Tom de Vries's message of "Thu, 28 Mar 2024 15:33:13 +0100") Message-ID: <87ttkl9i38.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.3 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - box5379.bluehost.com X-AntiAbuse: Original Domain - sourceware.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - tromey.com X-BWhitelist: no X-Source-IP: 97.122.82.115 X-Source-L: No X-Exim-ID: 1rrKHr-001Z0u-2W X-Source: X-Source-Args: X-Source-Dir: X-Source-Sender: 97-122-82-115.hlrn.qwest.net (murgatroyd) [97.122.82.115]:42890 X-Source-Auth: tom+tromey.com X-Email-Count: 7 X-Org: HG=bhshared;ORG=bluehost; X-Source-Cap: ZWx5bnJvYmk7ZWx5bnJvYmk7Ym94NTM3OS5ibHVlaG9zdC5jb20= X-Local-Domain: yes X-CMAE-Envelope: MS4xfCd8Rp1l4WjEMOTbmvFI/pSUrZGwFhpwvSHlPXu/iC16BIxK9V3tfts/pdynnD883Arv0fQTkzYzlDH2+LdPHBLnsBqVkglpK+FNVAvA053LD6R+tXtY uVIawi2SBTrDOVIUaBvret8u/JQUirylEUVdV6Ti3/7IfGuRJttAfBllwEhCbp1zbtaYRvaqydwVkwAxwtddvP8Aw6FXQK9nTUg= X-Spam-Status: No, score=-3015.5 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, JMQ_SPF_NEUTRAL, RCVD_IN_MSPIKE_H2, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces+public-inbox=simark.ca@sourceware.org >>>>> "Tom" == Tom de Vries writes: Tom> Fix these problems respectively by: Tom> - in tui_enable, instead of "tui_show_frame_info (0)" using Tom> 'tui_show_frame_info (deprecated_safe_get_selected_frame ())", and Tom> - in tui_source_window_base::rerender, adding centering functionality. Thanks. Approved-By: Tom Tromey Tom> + /* This centering code is copied from tui_source_window::maybe_update. Tom> + It would be nice to do centering more often, and do it in just one Tom> + location. But since this is a regression fix, handle this Tom> + conservatively for now. */ Yeah, unfortunately some of this code remains spaghetti from the old days. Tom