[PATCH] gdb: Add svr4-tls-tdep.o to list of objects of i*86 targets

[PATCH] gdb: Add svr4-tls-tdep.o to list of objects of i*86 targets

[Sergio Durigan Junior]

GDB currently fails to build from source on i386 if compiled with
--enable-64-bit-bfd.  This is happening because svr4-tls-tdep.o is
missing from the gdb_target_obs variable, while amd64-linux-tdep.o is
obviously there.

Fix the problem by adding svr4-tls-tdep.o to the object list, but only
when --enable-64-bit-bfd is provided.

Signed-off-by: Sergio Durigan Junior <sergiodj@sergiodj.net>
Bug: https://sourceware.org/bugzilla/show_bug.cgi?id=33399
---
 gdb/configure.tgt | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/gdb/configure.tgt b/gdb/configure.tgt
index f33d3de9214..34ae5036340 100644
--- a/gdb/configure.tgt
+++ b/gdb/configure.tgt
@@ -326,7 +326,7 @@ i[34567]86-*-linux*)
 			arch/x86-linux-tdesc-features.o"
 	if test "x$have_64_bit_bfd" = "xyes"; then
 	    # Target: GNU/Linux x86-64
-	    gdb_target_obs="amd64-linux-tdep.o \
+	    gdb_target_obs="amd64-linux-tdep.o svr4-tls-tdep.o \
 			    arch/amd64-linux-tdesc.o ${gdb_target_obs}"
 	fi
 	;;
-- 
2.50.1

Re: [PATCH] gdb: Add svr4-tls-tdep.o to list of objects of i*86 targets

[Sergio Durigan Junior]

On Sunday, September 07 2025, I wrote:

> GDB currently fails to build from source on i386 if compiled with
> --enable-64-bit-bfd.  This is happening because svr4-tls-tdep.o is
> missing from the gdb_target_obs variable, while amd64-linux-tdep.o is
> obviously there.
>
> Fix the problem by adding svr4-tls-tdep.o to the object list, but only
> when --enable-64-bit-bfd is provided.

By the way, this also affects the release candidate (17.0.90).  Could
you please remind me how I should proceed to get this reviewed/accepted
into the branch?

Thanks,

-- 
Sergio
GPG key ID: 237A 54B1 0287 28BF 00EF  31F4 D0EB 7628 65FC 5E36
Please send encrypted e-mail if possible
https://sergiodj.net/

Re: [PATCH] gdb: Add svr4-tls-tdep.o to list of objects of i*86 targets

[Tom Tromey]

Sergio> By the way, this also affects the release candidate (17.0.90).  Could
Sergio> you please remind me how I should proceed to get this reviewed/accepted
Sergio> into the branch?

It's ok for the branch as well, you can just git cherry-pick it there
and push.  I personally like "git cherry-pick -x" to record a link to
the original commit.

thanks,
Tom

Re: [PATCH] gdb: Add svr4-tls-tdep.o to list of objects of i*86 targets

[Sergio Durigan Junior]

On Monday, September 08 2025, Tom Tromey wrote:

> Sergio> By the way, this also affects the release candidate (17.0.90).  Could
> Sergio> you please remind me how I should proceed to get this reviewed/accepted
> Sergio> into the branch?
>
> It's ok for the branch as well, you can just git cherry-pick it there
> and push.  I personally like "git cherry-pick -x" to record a link to
> the original commit.

Thanks, pushed (now with the Approved-by stanza).

-- 
Sergio
GPG key ID: 237A 54B1 0287 28BF 00EF  31F4 D0EB 7628 65FC 5E36
Please send encrypted e-mail if possible
https://sergiodj.net/

Re: [PATCH] gdb: Add svr4-tls-tdep.o to list of objects of i*86 targets

[Tom Tromey]

>>>>> "Sergio" == Sergio Durigan Junior <sergiodj@sergiodj.net> writes:

Sergio> GDB currently fails to build from source on i386 if compiled with
Sergio> --enable-64-bit-bfd.  This is happening because svr4-tls-tdep.o is
Sergio> missing from the gdb_target_obs variable, while amd64-linux-tdep.o is
Sergio> obviously there.

Sergio> Fix the problem by adding svr4-tls-tdep.o to the object list, but only
Sergio> when --enable-64-bit-bfd is provided.

Sergio> Signed-off-by: Sergio Durigan Junior <sergiodj@sergiodj.net>
Sergio> Bug: https://sourceware.org/bugzilla/show_bug.cgi?id=33399

Ok, thank you.
Approved-By: Tom Tromey <tom@tromey.com>

Tom

Re: [PATCH] gdb: Add svr4-tls-tdep.o to list of objects of i*86 targets

[Sergio Durigan Junior]

On Monday, September 08 2025, Tom Tromey wrote:

>>>>>> "Sergio" == Sergio Durigan Junior <sergiodj@sergiodj.net> writes:
>
> Sergio> GDB currently fails to build from source on i386 if compiled with
> Sergio> --enable-64-bit-bfd.  This is happening because svr4-tls-tdep.o is
> Sergio> missing from the gdb_target_obs variable, while amd64-linux-tdep.o is
> Sergio> obviously there.
>
> Sergio> Fix the problem by adding svr4-tls-tdep.o to the object list, but only
> Sergio> when --enable-64-bit-bfd is provided.
>
> Sergio> Signed-off-by: Sergio Durigan Junior <sergiodj@sergiodj.net>
> Sergio> Bug: https://sourceware.org/bugzilla/show_bug.cgi?id=33399
>
> Ok, thank you.

Thanks, Tom!  Pushed.

> Approved-By: Tom Tromey <tom@tromey.com>

Oh shoot, I forgot to add this.  Hope it's fine.

-- 
Sergio
GPG key ID: 237A 54B1 0287 28BF 00EF  31F4 D0EB 7628 65FC 5E36
Please send encrypted e-mail if possible
https://sergiodj.net/