Re: [PATCH v2 2/7] gdb: update expanded_symbols_functions::find_pc_sect_compunit_symtab

[Tom Tromey <tom@tromey.com>]

>>>>> "Jan" == Jan Vrany <jan.vrany@labware.com> writes:

Jan> This commit updates expanded_symbols_functions::find_pc_sect_compunit_symtab
Jan> to search all compunits rather than just returning null.

Jan> The original implementation (just return null) was based on reasoning
Jan> that its would suffice since find_compunit_symtab_for_pc_sect walks
Jan> all CUs anyway [1]. This commit is a preparation to simplify
Jan> find_compunit_symtab_for_pc_sect by removing that code.

Jan> Approved-By: Tom Tromey <tom@tromey.com>
Jan> Bug: https://sourceware.org/bugzilla/show_bug.cgi?id=33829

Jan> +  for (compunit_symtab &symtab : objfile->compunits ())

This "conflicts" with Simon's change to
expanded_symbols_functions -- whichever patch lands second will have to
be updated to account for the patch that lands first.

I just wanted to make sure you both are aware.

I think the change should be just looping over the local compunits, and
as far as I'm concerned that qualifies as obvious.

thanks,
Tom