From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id +YbCCCeiqGkMjxQAWB0awg (envelope-from ) for ; Wed, 04 Mar 2026 16:20:39 -0500 Authentication-Results: simark.ca; dkim=fail reason="signature verification failed" (768-bit key; unprotected) header.d=tromey.com header.i=@tromey.com header.a=rsa-sha256 header.s=default header.b=gfLaG3QO; dkim-atps=neutral Received: by simark.ca (Postfix, from userid 112) id 044F81E0DD; Wed, 04 Mar 2026 16:20:39 -0500 (EST) X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-25) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-2.1 required=5.0 tests=ARC_SIGNED,ARC_VALID,BAYES_00, DKIM_INVALID,DKIM_SIGNED,MAILING_LIST_MULTI,RCVD_IN_DNSWL_MED, RCVD_IN_VALIDITY_CERTIFIED_BLOCKED,RCVD_IN_VALIDITY_RPBL_BLOCKED, RCVD_IN_VALIDITY_SAFE_BLOCKED autolearn=ham autolearn_force=no version=4.0.1 Received: from vm01.sourceware.org (vm01.sourceware.org [38.145.34.32]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 53A731E089 for ; Wed, 04 Mar 2026 16:20:37 -0500 (EST) Received: from vm01.sourceware.org (localhost [127.0.0.1]) by sourceware.org (Postfix) with ESMTP id BBFE44BA23FB for ; Wed, 4 Mar 2026 21:20:36 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org BBFE44BA23FB Authentication-Results: sourceware.org; dkim=fail reason="signature verification failed" (768-bit key, unprotected) header.d=tromey.com header.i=@tromey.com header.a=rsa-sha256 header.s=default header.b=gfLaG3QO Received: from omta036.useast.a.cloudfilter.net (omta036.useast.a.cloudfilter.net [44.202.169.35]) by sourceware.org (Postfix) with ESMTPS id 100644BA23C5 for ; Wed, 4 Mar 2026 21:20:04 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 100644BA23C5 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=tromey.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=tromey.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 100644BA23C5 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=44.202.169.35 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1772659204; cv=none; b=tqwSlmPT8/vQwKF7pvU/xZ2R7zbiiec1wYLmt6fMvFnWyKNcDEPE9nskEtWBTwavtEUB3TbLuTMe4bHXYAxsFRuDqCMD/GVRVzaWv/yAGUxqz6hpc9IXqdzPRLOLzMwnVuLlf2GC5jT+qAvcKlB+XWq+S1r2F8BRfz8MiNkaSWA= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1772659204; c=relaxed/simple; bh=ktKyjqELMwyXZ6ViGurxyoh1j3dlzlWeaK0dFUXEA3M=; h=DKIM-Signature:From:To:Subject:Date:Message-ID:MIME-Version; b=IQiHO0Y6m2bWR8HN6iVFlUFw2dJJZ/TMPgLoThcH3Min2FXJWqBCZGwoZpyjwhJ/+aSNJWXTk9WJoXLDI7hJt3l8mOJReAjIBzSa4zl9C7zryDuSMfhhNjACC0oNS99/8L55HCaR0KnVM53gTcxong9SfJmKLg67V1uIvh2kDK4= ARC-Authentication-Results: i=1; server2.sourceware.org DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 100644BA23C5 Received: from eig-obgw-5005b.ext.cloudfilter.net ([10.0.29.189]) by cmsmtp with ESMTPS id xsVsv28zLKXDJxtdTvVdKD; Wed, 04 Mar 2026 21:20:03 +0000 Received: from box5379.bluehost.com ([162.241.216.53]) by cmsmtp with ESMTPS id xtd6vtdU8jAxuxtd6vaaYl; Wed, 04 Mar 2026 21:19:40 +0000 X-Authority-Analysis: v=2.4 cv=EoDSrTcA c=1 sm=1 tr=0 ts=69a8a203 a=ApxJNpeYhEAb1aAlGBBbmA==:117 a=ApxJNpeYhEAb1aAlGBBbmA==:17 a=Yq5XynenixoA:10 a=ItBw4LHWJt0A:10 a=CCpqsmhAAAAA:8 a=TDl5R864AAAA:8 a=zstS-IiYAAAA:8 a=3rwVf1GFsEeooPbPuuQA:9 a=ul9cdbp4aOFLsgKbc677:22 a=4IKI_MBedZsHOhguCAbN:22 a=4G6NA9xxw8l3yy4pmD5M:22 a=DCx65vhANUyCzuf5D8fC:22 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=tromey.com; s=default; h=Content-Type:MIME-Version:Message-ID:Date:References:In-Reply-To :Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=eSMXTicmIiPkUGx35zvvVE+hWDEkKB4KdtLFLUirngY=; b=gfLaG3QOhUjJvjEJWc2BFWt8b1 8Dtu/SbWimrLWfO/Uh3HNgoFuCT43OYPY6PPrY1N9EeECYJcU3TyWLop0kYsg+A7nuA+Q7/128q0b v+7DoYuFYgFVtP/YF6Y4/224c; Received: from 75-166-225-82.hlrn.qwest.net ([75.166.225.82]:52438 helo=bapiya) by box5379.bluehost.com with esmtpsa (TLS1.3) tls TLS_AES_256_GCM_SHA384 (Exim 4.98.2) (envelope-from ) id 1vxtd6-00000003qpc-03GM; Wed, 04 Mar 2026 14:19:40 -0700 From: Tom Tromey To: Jan Vrany Cc: gdb-patches@sourceware.org, Tom Tromey , Simon Marchi Subject: Re: [PATCH v2 2/7] gdb: update expanded_symbols_functions::find_pc_sect_compunit_symtab In-Reply-To: <20260304165914.3209106-3-jan.vrany@labware.com> (Jan Vrany's message of "Wed, 4 Mar 2026 16:59:09 +0000") References: <20260304165914.3209106-1-jan.vrany@labware.com> <20260304165914.3209106-3-jan.vrany@labware.com> X-Attribution: Tom Date: Wed, 04 Mar 2026 14:19:38 -0700 Message-ID: <87tsuvmgwl.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - box5379.bluehost.com X-AntiAbuse: Original Domain - sourceware.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - tromey.com X-BWhitelist: no X-Source-IP: 75.166.225.82 X-Source-L: No X-Exim-ID: 1vxtd6-00000003qpc-03GM X-Source: X-Source-Args: X-Source-Dir: X-Source-Sender: 75-166-225-82.hlrn.qwest.net (bapiya) [75.166.225.82]:52438 X-Source-Auth: tom+tromey.com X-Email-Count: 4 X-Org: HG=bhshared;ORG=bluehost; X-Source-Cap: ZWx5bnJvYmk7ZWx5bnJvYmk7Ym94NTM3OS5ibHVlaG9zdC5jb20= X-Local-Domain: yes X-CMAE-Envelope: MS4xfEM2ZVoSDTcKYdJL5HgjdiwiNVKHG0XA0Moc4WegStdFvGQ9z15gtSISHOwzBXW0JPXtpz3IEEKxJBlMcdCuUbU1PjfIMreyJyMmDNiIhOH3CXYR5y5r PEul5bhLzmJiIfzCcEQDyTALJOFkfScXEui3gWZZHSERR9nCRJ9yLVFyneLklw2Y9tAauBY5XlHJdLM3O/C1boUiVcWYRPG+Y+c= X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces~public-inbox=simark.ca@sourceware.org >>>>> "Jan" == Jan Vrany writes: Jan> This commit updates expanded_symbols_functions::find_pc_sect_compunit_symtab Jan> to search all compunits rather than just returning null. Jan> The original implementation (just return null) was based on reasoning Jan> that its would suffice since find_compunit_symtab_for_pc_sect walks Jan> all CUs anyway [1]. This commit is a preparation to simplify Jan> find_compunit_symtab_for_pc_sect by removing that code. Jan> Approved-By: Tom Tromey Jan> Bug: https://sourceware.org/bugzilla/show_bug.cgi?id=33829 Jan> + for (compunit_symtab &symtab : objfile->compunits ()) This "conflicts" with Simon's change to expanded_symbols_functions -- whichever patch lands second will have to be updated to account for the patch that lands first. I just wanted to make sure you both are aware. I think the change should be just looping over the local compunits, and as far as I'm concerned that qualifies as obvious. thanks, Tom