Re: [PATCH v2 6/7] gdb/aarch64: Add core file support for FEAT_S1POE

[Thiago Jung Bauermann <thiago.bauermann@linaro.org>]

<srinath.parvathaneni@arm.com> writes:

> From: Srinath Parvathaneni <srinath.parvathaneni@arm.com>
>
> Add support for POR_EL0 dumps/reads for core files.

This descriptions is incomplete. The patch is also about adding support
for reading the POE value in the signal frame.

> ---
>  gdb/aarch64-linux-tdep.c | 51 ++++++++++++++++++++++++++++++++++++++++
>  1 file changed, 51 insertions(+)
>
> diff --git a/gdb/aarch64-linux-tdep.c b/gdb/aarch64-linux-tdep.c
> index b8a02ab9972..1d6d4c94b84 100644
> --- a/gdb/aarch64-linux-tdep.c
> +++ b/gdb/aarch64-linux-tdep.c
> @@ -171,6 +171,7 @@
>  #define AARCH64_ZT_MAGIC			0x5a544e01
>  #define AARCH64_GCS_MAGIC			0x47435300
>  #define AARCH64_FPMR_MAGIC			0x46504d52
> +#define AARCH64_POE_MAGIC			0x504f4530
>  
>  /* Defines for the extra_context that follows an AARCH64_EXTRA_MAGIC.  */
>  #define AARCH64_EXTRA_DATAP_OFFSET		8
> @@ -220,6 +221,9 @@
>  /* FPMR constants.  */
>  #define AARCH64_FPMR_OFFSET			8
>  
> +/* POE constants.  */
> +#define AARCH64_POE_OFFSET			8
> +
>  /* Holds information about the signal frame.  */
>  struct aarch64_linux_sigframe
>  {
> @@ -273,6 +277,11 @@ struct aarch64_linux_sigframe
>    /* FPMR value.  */
>    CORE_ADDR fpmr = 0;
>  
> +  /* True if we have an POE entry in the signal context, false otherwise.  */
> +  bool poe_available = false;
> +  /* FPMR value.  */
> +  CORE_ADDR poe = 0;
> +

Extraneous empty line.

>  };
>  
>  /* Read an aarch64_ctx, returning the magic value, and setting *SIZE to the
> @@ -605,6 +614,22 @@ aarch64_linux_read_signal_frame_info (const frame_info_ptr &this_frame,
>  	    section += size;
>  	    break;
>  	  }
> +	case AARCH64_POE_MAGIC:
> +	  {
> +	    gdb_byte buf[8];
> +	    if (target_read_memory (section + AARCH64_POE_OFFSET,
> +				    buf, 8) != 0)
> +	      {
> +		warning (_("Failed to read the POE section address from the"
> +			   " signal frame context."));
> +		section += size;
> +		break;
> +	      }
> +	    signal_frame.poe = extract_unsigned_integer (buf, 8, byte_order);
> +	    signal_frame.poe_available = true;
> +	    section += size;
> +	    break;
> +	  }
>  	case AARCH64_EXTRA_MAGIC:
>  	  {
>  	    /* Extra is always the last valid section in reserved and points to
> @@ -775,6 +800,13 @@ aarch64_linux_sigframe_init (const struct tramp_frame *self,
>  			      signal_frame.fpmr);
>    }
>  
> +  /* Handle POE register.  */
> +  if (tdep->has_poe () && signal_frame.poe_available != 0)

poe_available is a boolean, so you can just use "&&
signal_frame.poe_available".

> +  {
> +    trad_frame_set_reg_value (this_cache, tdep->poe_regnum,
> +			      signal_frame.poe);
> +  }
> +
>    /* Restore the tpidr2 register, if the target supports it and if there is
>       an entry for it.  */
>    if (signal_frame.tpidr2_section != 0 && tdep->has_tls ()

-- 
Thiago
(he/him)