Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Marc Zyngier <maz@kernel.org>
To: Thiago Jung Bauermann <thiago.bauermann@linaro.org>
Cc: Srinath Parvathaneni <Srinath.Parvathaneni@arm.com>,
	"gdb-patches@sourceware.org" <gdb-patches@sourceware.org>,
	"luis.machado.foss@gmail.com" <luis.machado.foss@gmail.com>,
	"guinevere@redhat.com" <guinevere@redhat.com>,
	Ezra Sitorus <Ezra.Sitorus@arm.com>,
	Matthieu Longo <Matthieu.Longo@arm.com>,
	Mark Rutland <Mark.Rutland@arm.com>
Subject: Re: [PATCH v2 1/7] gdb/aarch64: Add POR_EL0 register support for FEAT_S1POE
Date: Wed, 01 Jul 2026 15:45:02 +0100	[thread overview]
Message-ID: <86se62py4x.wl-maz@kernel.org> (raw)
In-Reply-To: <874iijguhm.fsf@linaro.org>

On Wed, 01 Jul 2026 06:16:21 +0100,
Thiago Jung Bauermann <thiago.bauermann@linaro.org> wrote:
> 
> Hello Srinath,
> 
> Srinath Parvathaneni <Srinath.Parvathaneni@arm.com> writes:
> 
> >>> *  info registers por_el0
> >>> *  p $por_el0
> >>> *  p/x $por_el0
> >>> *  set $por_el0 = <value>
> >>
> >>One question, more about general policy on the AArch64 GDB port:
> >>
> >>Should the register name have the _el0 suffix? It's more than half of
> >>the register name (though tab completion helps).
> >>
> >>We don't currently have that suffix in the name of any register. And in
> >>the case of Guarded Control Stack, I didn't add it. For native
> >>debugging, it will always be the register at EL0. For remote debugging,
> >>I assumed the target would send the register corresponding to the
> >>current exception level in the inferior.
> >>
> >>Can there be a situation where it would be possible to see both the EL0
> >>and EL1 (for example) registers at the same time? Or a situation where
> >>the inferior is at EL1 but one wants to see the register at EL0, or
> >>vice-versa?
> >>
> >
> > Thanks Thiago for the review. I'll address the other review comments and
> > post a new version of the patches.
> >
> > I'm happy to follow the existing AArch64 GDB convention and expose the register
> > as `POR` for consistency.
> >
> > That said, after discussing this with kernel/KVM developers, there are valid
> > debugging scenarios (e.g. KGDB or guest debugging via KVM/QEMU) where exposing
> > `POR_EL0`, `POR_EL1`, and `POR_EL2` simultaneously would be useful.
> 
> Thanks for checking! Considering it's indeed useful then it's better to
> use $por_el0 in this patch series as you have done.
> 
> > This seems like a broader GDB register naming issue rather than
> > something specific to FEAT_S1POE.
> 
> I agree. This just seemed like a good moment to consider this question.

It would certainly make our life easier if GDB was in general adopting
the architecture nomenclature.

It is probably fine to have a "shorthand" such as POR for POR_EL0, but
I'd like to make sure that it is possible to unambiguously target the
correct register for the cases where we have to debug a full guest
(which is something people actively do using the QEMU GDB stubs).

Thanks,

	M.

-- 
Without deviation from the norm, progress is not possible.

  reply	other threads:[~2026-07-01 14:46 UTC|newest]

Thread overview: 21+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-06-26 18:08 [PATCH v2 0/7] gdb/aarch64: Add support for FEAT_S1POE feature srinath.parvathaneni
2026-06-26 18:08 ` [PATCH v2 1/7] gdb/aarch64: Add POR_EL0 register support for FEAT_S1POE srinath.parvathaneni
2026-06-27  6:06   ` Thiago Jung Bauermann
2026-06-29 10:44     ` Srinath Parvathaneni
2026-07-01  5:16       ` Thiago Jung Bauermann
2026-07-01 14:45         ` Marc Zyngier [this message]
2026-06-26 18:08 ` [PATCH v2 2/7] gdb/aarch64: Add custom printing for POR_EL0 srinath.parvathaneni
2026-06-27  7:03   ` Thiago Jung Bauermann
2026-06-29  7:02     ` Srinath Parvathaneni
2026-06-29 15:58       ` Ezra Sitorus
2026-06-26 18:08 ` [PATCH v2 3/7] gdb: Improve SIGSEGV diagnostics for POE faults srinath.parvathaneni
2026-06-29  2:42   ` Thiago Jung Bauermann
2026-06-26 18:08 ` [PATCH v2 4/7] gdbserver/aarch64: Add POR_EL0 register support srinath.parvathaneni
2026-06-29  2:43   ` Thiago Jung Bauermann
2026-06-26 18:08 ` [PATCH v2 5/7] bfd/readelf: Add core file support for FEAT_S1POE srinath.parvathaneni
2026-06-29  2:43   ` Thiago Jung Bauermann
2026-06-26 18:08 ` [PATCH v2 6/7] gdb/aarch64: " srinath.parvathaneni
2026-06-29  2:44   ` Thiago Jung Bauermann
2026-06-26 18:08 ` [PATCH v2 7/7] gdb/testsuite: Add FEAT_S1POE testcases srinath.parvathaneni
2026-07-01  5:12   ` Thiago Jung Bauermann
2026-06-29 12:18 ` [PATCH v2 0/7] gdb/aarch64: Add support for FEAT_S1POE feature Guinevere Larsen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=86se62py4x.wl-maz@kernel.org \
    --to=maz@kernel.org \
    --cc=Ezra.Sitorus@arm.com \
    --cc=Mark.Rutland@arm.com \
    --cc=Matthieu.Longo@arm.com \
    --cc=Srinath.Parvathaneni@arm.com \
    --cc=gdb-patches@sourceware.org \
    --cc=guinevere@redhat.com \
    --cc=luis.machado.foss@gmail.com \
    --cc=thiago.bauermann@linaro.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox