From: Tom Tromey <tromey@redhat.com>
To: Jan Kratochvil <jan.kratochvil@redhat.com>
Cc: gdb-patches@sourceware.org
Subject: Re: [patch] Fix "ambiguous linespec" regression: break lineno
Date: Mon, 11 Jun 2012 15:15:00 -0000 [thread overview]
Message-ID: <87sje198yq.fsf@fleche.redhat.com> (raw)
In-Reply-To: <20120610190308.GA23551@host2.jankratochvil.net> (Jan Kratochvil's message of "Sun, 10 Jun 2012 21:03:08 +0200")
>>>>> "Jan" == Jan Kratochvil <jan.kratochvil@redhat.com> writes:
Jan> I have some draft patch almost without regressions but those two
Jan> locations had some logic. "break" should put breakpoint to the
Jan> current frame and not to some last arbitrary line listed.
Ok, I see.
>> I realize you're just reverting a bit of code - but is that ObjC hack
>> really needed? I'd like us to get away from this kind of thing.
Jan> It needs to detect the pattern ^[+-] (for 'break +5', 'break -3'
Jan> etc.) but it should not get confused by the ObjC breakpoints for
Jan> -[func] or +[func].
Jan> I agree if the two locations get unified it is no longer needed.
I wonder if it would be cleaner as a flag to linespec.
That's just speculation, please don't consider it an objection.
I think you can go ahead as you like.
Tom
next prev parent reply other threads:[~2012-06-11 15:15 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-06-08 19:40 Jan Kratochvil
2012-06-08 20:41 ` Tom Tromey
2012-06-08 22:19 ` Matt Rice
2012-06-11 15:21 ` Jan Kratochvil
2012-06-10 19:03 ` Jan Kratochvil
2012-06-11 15:15 ` Tom Tromey [this message]
2012-06-11 19:17 ` [commit] " Jan Kratochvil
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87sje198yq.fsf@fleche.redhat.com \
--to=tromey@redhat.com \
--cc=gdb-patches@sourceware.org \
--cc=jan.kratochvil@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox