From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 3335 invoked by alias); 11 Jun 2012 15:15:00 -0000 Received: (qmail 3322 invoked by uid 22791); 11 Jun 2012 15:14:59 -0000 X-SWARE-Spam-Status: No, hits=-6.5 required=5.0 tests=AWL,BAYES_00,KHOP_RCVD_UNTRUST,RCVD_IN_DNSWL_HI,RCVD_IN_HOSTKARMA_W,SPF_HELO_PASS,T_RP_MATCHES_RCVD X-Spam-Check-By: sourceware.org Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Mon, 11 Jun 2012 15:14:39 +0000 Received: from int-mx12.intmail.prod.int.phx2.redhat.com (int-mx12.intmail.prod.int.phx2.redhat.com [10.5.11.25]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id q5BFEdDJ015748 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Mon, 11 Jun 2012 11:14:39 -0400 Received: from barimba (ovpn01.gateway.prod.ext.phx2.redhat.com [10.5.9.1]) by int-mx12.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id q5BFEbAG019587 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES128-SHA bits=128 verify=NO); Mon, 11 Jun 2012 11:14:38 -0400 From: Tom Tromey To: Jan Kratochvil Cc: gdb-patches@sourceware.org Subject: Re: [patch] Fix "ambiguous linespec" regression: break lineno References: <20120608193958.GA10296@host2.jankratochvil.net> <87ehppczag.fsf@fleche.redhat.com> <20120610190308.GA23551@host2.jankratochvil.net> Date: Mon, 11 Jun 2012 15:15:00 -0000 In-Reply-To: <20120610190308.GA23551@host2.jankratochvil.net> (Jan Kratochvil's message of "Sun, 10 Jun 2012 21:03:08 +0200") Message-ID: <87sje198yq.fsf@fleche.redhat.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2012-06/txt/msg00284.txt.bz2 >>>>> "Jan" == Jan Kratochvil writes: Jan> I have some draft patch almost without regressions but those two Jan> locations had some logic. "break" should put breakpoint to the Jan> current frame and not to some last arbitrary line listed. Ok, I see. >> I realize you're just reverting a bit of code - but is that ObjC hack >> really needed? I'd like us to get away from this kind of thing. Jan> It needs to detect the pattern ^[+-] (for 'break +5', 'break -3' Jan> etc.) but it should not get confused by the ObjC breakpoints for Jan> -[func] or +[func]. Jan> I agree if the two locations get unified it is no longer needed. I wonder if it would be cleaner as a flag to linespec. That's just speculation, please don't consider it an objection. I think you can go ahead as you like. Tom