From: Tom Tromey <tromey@redhat.com>
To: Yao Qi <yao@codesourcery.com>
Cc: <gdb-patches@sourceware.org>
Subject: Re: [PATCH 3/3] remove TYPE_CODE_BITSTRING
Date: Fri, 10 Aug 2012 16:19:00 -0000 [thread overview]
Message-ID: <87sjbuafeq.fsf@fleche.redhat.com> (raw)
In-Reply-To: <1344589936-2006-4-git-send-email-yao@codesourcery.com> (Yao Qi's message of "Fri, 10 Aug 2012 17:12:16 +0800")
>>>>> "Yao" == Yao Qi <yao@codesourcery.com> writes:
Yao> 2012-08-10 Yao Qi <yao@codesourcery.com>
Yao> * gdbtypes.h (enum type_code): Remove TYPE_CODE_BITSTRING.
This one needs a little tweak.
Yao> diff --git a/gdb/python/py-type.c b/gdb/python/py-type.c
Yao> index 98030a6..dc7af9f 100644
Yao> --- a/gdb/python/py-type.c
Yao> +++ b/gdb/python/py-type.c
Yao> @@ -98,7 +98,6 @@ static struct pyty_code pyty_codes[] =
Yao> ENTRY (TYPE_CODE_SET),
Yao> ENTRY (TYPE_CODE_RANGE),
Yao> ENTRY (TYPE_CODE_STRING),
Yao> - ENTRY (TYPE_CODE_BITSTRING),
This is actually Python API. Search for TYPE_CODE_BITSTRING in the
manual.
I think it is best to keep the name around, in case anything uses it.
But, we don't have to keep the same value. So I would suggest defining
to be -1 and then updating the manual to note that this code is
deprecated -- or even just undocumenting the constant.
The rest is ok though.
Tom
next prev parent reply other threads:[~2012-08-10 16:19 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-08-10 9:13 [RFC 0/3] Remove unused operators OP_BITSTRING TERNOP_SLICE_COUNT and TYPE_CODE_BITSTRING Yao Qi
2012-08-10 9:13 ` [PATCH 2/3] Remove TERNOP_SLICE_COUNT Yao Qi
2012-08-10 16:16 ` Tom Tromey
2012-08-10 9:13 ` [PATCH 3/3] remove TYPE_CODE_BITSTRING Yao Qi
2012-08-10 16:19 ` Tom Tromey [this message]
2012-08-13 1:13 ` Yao Qi
2012-08-15 19:39 ` Tom Tromey
2012-08-10 9:13 ` [PATCH 1/3] Remove OP_BITSTRING Yao Qi
2012-08-10 16:16 ` Tom Tromey
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87sjbuafeq.fsf@fleche.redhat.com \
--to=tromey@redhat.com \
--cc=gdb-patches@sourceware.org \
--cc=yao@codesourcery.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox