From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 8686 invoked by alias); 10 Aug 2012 16:19:27 -0000 Received: (qmail 8678 invoked by uid 22791); 10 Aug 2012 16:19:26 -0000 X-SWARE-Spam-Status: No, hits=-6.5 required=5.0 tests=AWL,BAYES_00,KHOP_RCVD_UNTRUST,RCVD_IN_DNSWL_HI,RCVD_IN_HOSTKARMA_W,SPF_HELO_PASS,T_RP_MATCHES_RCVD X-Spam-Check-By: sourceware.org Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Fri, 10 Aug 2012 16:19:13 +0000 Received: from int-mx02.intmail.prod.int.phx2.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id q7AGJAS3019907 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Fri, 10 Aug 2012 12:19:10 -0400 Received: from barimba (ovpn01.gateway.prod.ext.phx2.redhat.com [10.5.9.1]) by int-mx02.intmail.prod.int.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id q7AGJ9HI007796 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES128-SHA bits=128 verify=NO); Fri, 10 Aug 2012 12:19:10 -0400 From: Tom Tromey To: Yao Qi Cc: Subject: Re: [PATCH 3/3] remove TYPE_CODE_BITSTRING References: <1344589936-2006-1-git-send-email-yao@codesourcery.com> <1344589936-2006-4-git-send-email-yao@codesourcery.com> Date: Fri, 10 Aug 2012 16:19:00 -0000 In-Reply-To: <1344589936-2006-4-git-send-email-yao@codesourcery.com> (Yao Qi's message of "Fri, 10 Aug 2012 17:12:16 +0800") Message-ID: <87sjbuafeq.fsf@fleche.redhat.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2012-08/txt/msg00318.txt.bz2 >>>>> "Yao" == Yao Qi writes: Yao> 2012-08-10 Yao Qi Yao> * gdbtypes.h (enum type_code): Remove TYPE_CODE_BITSTRING. This one needs a little tweak. Yao> diff --git a/gdb/python/py-type.c b/gdb/python/py-type.c Yao> index 98030a6..dc7af9f 100644 Yao> --- a/gdb/python/py-type.c Yao> +++ b/gdb/python/py-type.c Yao> @@ -98,7 +98,6 @@ static struct pyty_code pyty_codes[] = Yao> ENTRY (TYPE_CODE_SET), Yao> ENTRY (TYPE_CODE_RANGE), Yao> ENTRY (TYPE_CODE_STRING), Yao> - ENTRY (TYPE_CODE_BITSTRING), This is actually Python API. Search for TYPE_CODE_BITSTRING in the manual. I think it is best to keep the name around, in case anything uses it. But, we don't have to keep the same value. So I would suggest defining to be -1 and then updating the manual to note that this code is deprecated -- or even just undocumenting the constant. The rest is ok though. Tom