From: Tom Tromey <tromey@redhat.com>
To: "Pierre Muller" <pierre.muller@ics-cnrs.unistra.fr>
Cc: <gdb-patches@sourceware.org>
Subject: Re: [RFA] Avoid calling stat with empty name in relocate_gdb_directory
Date: Wed, 05 Dec 2012 18:03:00 -0000 [thread overview]
Message-ID: <87sj7ks7g6.fsf@fleche.redhat.com> (raw)
In-Reply-To: <29503.7594777115$1354726985@news.gmane.org> (Pierre Muller's message of "Wed, 5 Dec 2012 18:01:59 +0100")
>>>>> "Pierre" == Pierre Muller <pierre.muller@ics-cnrs.unistra.fr> writes:
Pierre> With the troubles that I have with my patch,
Pierre> I started looking into a memory debugger...
Pierre> I finally started to use drmemory
Pierre> for mingw compiled GDB executables.
Pierre> I don't know if stat is supposed to handle (*dir == '\0'),
Pierre> but I thought that it should anyhow succeed in that case,
Pierre> so the patch below simply don't call stat if name is empty.
At least here I get an error.
Pierre> Tell me if you rather think that this is a msvcrt bug that
Pierre> should not be fixed in GDB...
I don't mind working around it, but I wonder how we end up there with an
empty 'dir' in the first place. Perhaps that is a bug instead.
Tom
next parent reply other threads:[~2012-12-05 18:03 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <29503.7594777115$1354726985@news.gmane.org>
2012-12-05 18:03 ` Tom Tromey [this message]
2012-12-05 23:45 ` Pierre Muller
[not found] ` <434.327257289802$1354751122@news.gmane.org>
2012-12-06 18:33 ` Tom Tromey
2012-12-14 8:17 ` Pierre Muller
[not found] ` <26262.2907328934$1355473042@news.gmane.org>
2013-01-03 20:59 ` Tom Tromey
2013-01-03 22:19 ` Pierre Muller
2012-12-05 17:02 Pierre Muller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87sj7ks7g6.fsf@fleche.redhat.com \
--to=tromey@redhat.com \
--cc=gdb-patches@sourceware.org \
--cc=pierre.muller@ics-cnrs.unistra.fr \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox