From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 22959 invoked by alias); 5 Dec 2012 18:03:09 -0000 Received: (qmail 22951 invoked by uid 22791); 5 Dec 2012 18:03:07 -0000 X-SWARE-Spam-Status: No, hits=-6.5 required=5.0 tests=AWL,BAYES_00,KHOP_RCVD_UNTRUST,KHOP_SPAMHAUS_DROP,RCVD_IN_DNSWL_HI,RCVD_IN_HOSTKARMA_W,RP_MATCHES_RCVD,SPF_HELO_PASS X-Spam-Check-By: sourceware.org Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Wed, 05 Dec 2012 18:02:55 +0000 Received: from int-mx09.intmail.prod.int.phx2.redhat.com (int-mx09.intmail.prod.int.phx2.redhat.com [10.5.11.22]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id qB5I2p6P012342 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Wed, 5 Dec 2012 13:02:51 -0500 Received: from barimba (ovpn01.gateway.prod.ext.phx2.redhat.com [10.5.9.1]) by int-mx09.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id qB5I2n6W011082 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES128-SHA bits=128 verify=NO); Wed, 5 Dec 2012 13:02:50 -0500 From: Tom Tromey To: "Pierre Muller" Cc: Subject: Re: [RFA] Avoid calling stat with empty name in relocate_gdb_directory References: <29503.7594777115$1354726985@news.gmane.org> Date: Wed, 05 Dec 2012 18:03:00 -0000 In-Reply-To: <29503.7594777115$1354726985@news.gmane.org> (Pierre Muller's message of "Wed, 5 Dec 2012 18:01:59 +0100") Message-ID: <87sj7ks7g6.fsf@fleche.redhat.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2012-12/txt/msg00084.txt.bz2 >>>>> "Pierre" == Pierre Muller writes: Pierre> With the troubles that I have with my patch, Pierre> I started looking into a memory debugger... Pierre> I finally started to use drmemory Pierre> for mingw compiled GDB executables. Pierre> I don't know if stat is supposed to handle (*dir == '\0'), Pierre> but I thought that it should anyhow succeed in that case, Pierre> so the patch below simply don't call stat if name is empty. At least here I get an error. Pierre> Tell me if you rather think that this is a msvcrt bug that Pierre> should not be fixed in GDB... I don't mind working around it, but I wonder how we end up there with an empty 'dir' in the first place. Perhaps that is a bug instead. Tom