Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Tom Tromey <tromey@redhat.com>
To: Jan Kratochvil <jan.kratochvil@redhat.com>
Cc: Eli Zaretskii <eliz@gnu.org>,
	gdb-patches@sourceware.org,        hal9000ed2k@gmail.com
Subject: Re: [patchv2] GDB 7.2: new feature for "backtrace" that cuts path to file (remain filename)
Date: Wed, 05 Dec 2012 21:38:00 -0000	[thread overview]
Message-ID: <87sj7kqiwa.fsf@fleche.redhat.com> (raw)
In-Reply-To: <20121201175527.GA21574@host2.jankratochvil.net> (Jan	Kratochvil's message of "Sat, 1 Dec 2012 18:55:27 +0100")

>>>>> "Jan" == Jan Kratochvil <jan.kratochvil@redhat.com> writes:

Jan> +  if (filename == NULL)
Jan> +      return NULL;
Jan> +  else if (filename_display_string == filename_display_basename)
Jan> +      return lbasename (filename);

The two 'return' lines are indented incorrectly.

Jan> +set testfile "dw2-dir-file-name"
Jan> +set executable ${testfile}
Jan> +set binfile ${objdir}/${subdir}/${executable}
Jan> +set srcfile ${testfile}.c
Jan> +set asmsrcfile ${objdir}/${subdir}/${testfile}asm.S
Jan> +set asmobjfile ${objdir}/${subdir}/${testfile}asm.o
Jan> +set srcabsdir ${objdir}/${subdir}/${testfile}.d
Jan> +set srctmpfile tmp-${testfile}.c

standard_testfile please.

Jan> +proc out_cu { name cu_dir cu_name line_dir line_name } {

I like my DWARF assembler better ;-)

Tom


  reply	other threads:[~2012-12-05 21:38 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-11-30 18:57 Jan Kratochvil
2012-11-30 20:22 ` Eli Zaretskii
2012-12-01 17:28   ` Jan Kratochvil
2012-12-01 17:33     ` Eli Zaretskii
2012-12-01 17:55       ` Jan Kratochvil
2012-12-05 21:38         ` Tom Tromey [this message]
2012-12-06 10:04           ` Jan Kratochvil
2012-11-30 23:09 ` iam ahal
2012-12-01 17:15   ` Jan Kratochvil
2012-12-02 16:39     ` iam ahal
2012-12-03 10:11 ` Andrew Burgess
2012-12-03 13:21   ` Jan Kratochvil

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87sj7kqiwa.fsf@fleche.redhat.com \
    --to=tromey@redhat.com \
    --cc=eliz@gnu.org \
    --cc=gdb-patches@sourceware.org \
    --cc=hal9000ed2k@gmail.com \
    --cc=jan.kratochvil@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox