From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-patches-return-96620-listarch-gdb-patches=sources.redhat.com@sourceware.org>
Received: (qmail 17399 invoked by alias); 5 Dec 2012 21:38:41 -0000
Received: (qmail 17303 invoked by uid 22791); 5 Dec 2012 21:38:39 -0000
X-SWARE-Spam-Status: No, hits=-6.4 required=5.0	tests=AWL,BAYES_00,KHOP_RCVD_UNTRUST,KHOP_SPAMHAUS_DROP,RCVD_IN_DNSWL_HI,RCVD_IN_HOSTKARMA_W,RP_MATCHES_RCVD,SPF_HELO_PASS,TW_BJ
X-Spam-Check-By: sourceware.org
Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28)    by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Wed, 05 Dec 2012 21:38:33 +0000
Received: from int-mx12.intmail.prod.int.phx2.redhat.com (int-mx12.intmail.prod.int.phx2.redhat.com [10.5.11.25])	by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id qB5LcVMB016250	(version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK);	Wed, 5 Dec 2012 16:38:31 -0500
Received: from barimba (ovpn01.gateway.prod.ext.phx2.redhat.com [10.5.9.1])	by int-mx12.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id qB5LcTm6003699	(version=TLSv1/SSLv3 cipher=DHE-RSA-AES128-SHA bits=128 verify=NO);	Wed, 5 Dec 2012 16:38:30 -0500
From: Tom Tromey <tromey@redhat.com>
To: Jan Kratochvil <jan.kratochvil@redhat.com>
Cc: Eli Zaretskii <eliz@gnu.org>, gdb-patches@sourceware.org,        hal9000ed2k@gmail.com
Subject: Re: [patchv2] GDB 7.2: new feature for "backtrace" that cuts path to file (remain filename)
References: <20121130185653.GA15394@host2.jankratochvil.net>	<83lidiu9im.fsf@gnu.org>	<20121201172732.GB20612@host2.jankratochvil.net>	<837gp1u18h.fsf@gnu.org>	<20121201175527.GA21574@host2.jankratochvil.net>
Date: Wed, 05 Dec 2012 21:38:00 -0000
In-Reply-To: <20121201175527.GA21574@host2.jankratochvil.net> (Jan	Kratochvil's message of "Sat, 1 Dec 2012 18:55:27 +0100")
Message-ID: <87sj7kqiwa.fsf@fleche.redhat.com>
User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.2 (gnu/linux)
MIME-Version: 1.0
Content-Type: text/plain
Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <gdb-patches.sourceware.org>
List-Subscribe: <mailto:gdb-patches-subscribe@sourceware.org>
List-Archive: <http://sourceware.org/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sourceware.org>
List-Help: <mailto:gdb-patches-help@sourceware.org>, <http://sourceware.org/ml/#faqs>
Sender: gdb-patches-owner@sourceware.org
X-SW-Source: 2012-12/txt/msg00093.txt.bz2

>>>>> "Jan" == Jan Kratochvil <jan.kratochvil@redhat.com> writes:

Jan> +  if (filename == NULL)
Jan> +      return NULL;
Jan> +  else if (filename_display_string == filename_display_basename)
Jan> +      return lbasename (filename);

The two 'return' lines are indented incorrectly.

Jan> +set testfile "dw2-dir-file-name"
Jan> +set executable ${testfile}
Jan> +set binfile ${objdir}/${subdir}/${executable}
Jan> +set srcfile ${testfile}.c
Jan> +set asmsrcfile ${objdir}/${subdir}/${testfile}asm.S
Jan> +set asmobjfile ${objdir}/${subdir}/${testfile}asm.o
Jan> +set srcabsdir ${objdir}/${subdir}/${testfile}.d
Jan> +set srctmpfile tmp-${testfile}.c

standard_testfile please.

Jan> +proc out_cu { name cu_dir cu_name line_dir line_name } {

I like my DWARF assembler better ;-)

Tom