From: Tom Tromey <tromey@redhat.com>
To: Yao Qi <yao@codesourcery.com>
Cc: <gdb-patches@sourceware.org>
Subject: Re: [PATCH] Rename psymtab_to_symtab to read_symtab
Date: Wed, 16 Jan 2013 16:31:00 -0000 [thread overview]
Message-ID: <87sj61gkep.fsf@fleche.redhat.com> (raw)
In-Reply-To: <1358350197-24304-1-git-send-email-yao@codesourcery.com> (Yao Qi's message of "Wed, 16 Jan 2013 23:29:57 +0800")
>>>>> "Yao" == Yao Qi <yao@codesourcery.com> writes:
Yao> During review the patch, we find it is more clear to either rename
Yao> FOO_psymtab_to_symtab to FOO_read_symtab or rename field 'read_symtab'
Yao> in 'struct partial_symtab' to 'psymtab_to_symtab'. See the discussion
Yao> here <http://sourceware.org/ml/gdb-patches/2013-01/msg00238.html>
Thanks for doing this.
Yao> - dbx_psymtab_to_symtab_1 (objfile, pst);
Yao> + dbx_psymtab_to_symtab_1 (objfile, self);
It seems slightly odd to rename the containing functions and reorder
their arguments, but not apply the same treatment to the worker
functions.
However, I don't mind. This patch is ok.
If you want to fix up the _1 functions as well, that is ok too.
Tom
next prev parent reply other threads:[~2013-01-16 16:31 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-01-16 15:30 Yao Qi
2013-01-16 16:31 ` Tom Tromey [this message]
2013-01-18 3:16 ` committed: " Yao Qi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87sj61gkep.fsf@fleche.redhat.com \
--to=tromey@redhat.com \
--cc=gdb-patches@sourceware.org \
--cc=yao@codesourcery.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox