From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 766 invoked by alias); 16 Jan 2013 16:31:50 -0000 Received: (qmail 744 invoked by uid 22791); 16 Jan 2013 16:31:47 -0000 X-SWARE-Spam-Status: No, hits=-6.4 required=5.0 tests=AWL,BAYES_00,KHOP_RCVD_UNTRUST,RCVD_IN_DNSWL_HI,RP_MATCHES_RCVD,SPF_HELO_PASS X-Spam-Check-By: sourceware.org Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Wed, 16 Jan 2013 16:31:14 +0000 Received: from int-mx10.intmail.prod.int.phx2.redhat.com (int-mx10.intmail.prod.int.phx2.redhat.com [10.5.11.23]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id r0GGUpqE014136 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Wed, 16 Jan 2013 11:31:13 -0500 Received: from barimba (ovpn01.gateway.prod.ext.phx2.redhat.com [10.5.9.1]) by int-mx10.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id r0GGUco7026196 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES128-SHA bits=128 verify=NO); Wed, 16 Jan 2013 11:30:42 -0500 From: Tom Tromey To: Yao Qi Cc: Subject: Re: [PATCH] Rename psymtab_to_symtab to read_symtab References: <1358350197-24304-1-git-send-email-yao@codesourcery.com> Date: Wed, 16 Jan 2013 16:31:00 -0000 In-Reply-To: <1358350197-24304-1-git-send-email-yao@codesourcery.com> (Yao Qi's message of "Wed, 16 Jan 2013 23:29:57 +0800") Message-ID: <87sj61gkep.fsf@fleche.redhat.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.2.91 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2013-01/txt/msg00341.txt.bz2 >>>>> "Yao" == Yao Qi writes: Yao> During review the patch, we find it is more clear to either rename Yao> FOO_psymtab_to_symtab to FOO_read_symtab or rename field 'read_symtab' Yao> in 'struct partial_symtab' to 'psymtab_to_symtab'. See the discussion Yao> here Thanks for doing this. Yao> - dbx_psymtab_to_symtab_1 (objfile, pst); Yao> + dbx_psymtab_to_symtab_1 (objfile, self); It seems slightly odd to rename the containing functions and reorder their arguments, but not apply the same treatment to the worker functions. However, I don't mind. This patch is ok. If you want to fix up the _1 functions as well, that is ok too. Tom