Oh dear. I regret to inform you that commit 23c4651c060c123493de004ef61d8ed052d46113 might be unfortunate

Oh dear. I regret to inform you that commit 23c4651c060c123493de004ef61d8ed052d46113 might be unfortunate

[gdb-buildbot]

My lords, ladies, gentlemen, members of the public.

It is a matter of great regret and sadness to inform you that commit:

	Fix "make install-strip" failure to install gdb-add-index.sh
	23c4651c060c123493de004ef61d8ed052d46113

might have made GDB unwell.  Since I am just your Butler BuildBot,
I kindly ask that a human superior officer double-check this.

Please note that if you are reading this message on gdb-patches, there might
be other builders broken.

You can find more details about the unfortunate breakage in the next messages.

Cheers,

Your GDB BuildBot.

Breakage on builder RHEL-s390x-m64, revision 23c4651c060c123493de004ef61d8ed052d46113

[gdb-buildbot]

Unfortunately it seems that there is a breakage on GDB.

Commit title: 'Fix "make install-strip" failure to install gdb-add-index.sh'
Revision: 23c4651c060c123493de004ef61d8ed052d46113

You can find more details below:

+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+

Buildslave:
	rhel-7_1-s390x-1

Full Build URL:
	<http://gdb-build.sergiodj.net/builders/RHEL-s390x-m64/builds/8277>

Commit(s) tested:
	23c4651c060c123493de004ef61d8ed052d46113

Author(s) (in the same order as the commits):
	Eli Zaretskii <eliz@gnu.org>

Subject:
	Fix "make install-strip" failure to install gdb-add-index.sh

Testsuite log (gdb.sum and gdb.log) URL(s):
	<http://gdb-build.sergiodj.net/results/RHEL-s390x-m64/23/23c4651c060c123493de004ef61d8ed052d46113/>

*** Failed to compiled GDB.  ***
============================

+++ The full log is too big to be posted here.
+++ These are the last 100 lines of it.

/home/dje/rhel-7_1-s390x-1/rhel-s390x/build/gdb/../../binutils-gdb/gdb/m2-exp.y:301.25-44: warning: rule useless in parser due to conflicts [-Wother]
                         { start_arglist(); }
                         ^^^^^^^^^^^^^^^^^^^^
  YACC   p-exp.c
config.status: executing depfiles commands
  YACC   rust-exp.c
  GEN    stamp-version
  GEN    xml-builtin.c
make[3]: Entering directory `/home/dje/rhel-7_1-s390x-1/rhel-s390x/build/gdb'
make[4]: Entering directory `/home/dje/rhel-7_1-s390x-1/rhel-s390x/build/gdb/build-gnulib'
make[5]: Entering directory `/home/dje/rhel-7_1-s390x-1/rhel-s390x/build/gdb/build-gnulib'
make[6]: Entering directory `/home/dje/rhel-7_1-s390x-1/rhel-s390x/build/gdb/build-gnulib/import'
  GEN      dirent.h
  GEN      alloca.h
  GEN      fcntl.h
  GEN      glob.h
  GEN      limits.h
  GEN      inttypes.h
  GEN      math.h
  GEN      signal.h
  GEN      stdint.h
  GEN      stdio.h
  GEN      stdlib.h
  GEN      string.h
  GEN      sys/stat.h
  GEN      sys/time.h
  GEN      time.h
  GEN      sys/types.h
  GEN      unistd.h
  GEN      wchar.h
  GEN      wctype.h
make  all-recursive
make[7]: Entering directory `/home/dje/rhel-7_1-s390x-1/rhel-s390x/build/gdb/build-gnulib/import'
make[8]: Entering directory `/home/dje/rhel-7_1-s390x-1/rhel-s390x/build/gdb/build-gnulib/import'
  CC       cloexec.o
  CC       dirname-lgpl.o
  CC       basename-lgpl.o
  CC       stripslash.o
  CC       exitfail.o
  CC       fd-hook.o
  CC       fd-safer-flag.o
  CC       dup-safer-flag.o
  CC       filenamecat-lgpl.o
  CC       getprogname.o
  CC       hard-locale.o
  CC       localcharset.o
  CC       malloca.o
  CC       math.o
  CC       openat-die.o
  CC       save-cwd.o
  CC       stat-time.o
  CC       strnlen1.o
  CC       tempname.o
  CC       unistd.o
  CC       dup-safer.o
  CC       fd-safer.o
  CC       pipe-safer.o
  CC       wctype-h.o
  CC       chdir-long.o
  CC       fcntl.o
  CC       glob.o
  CC       glob_pattern_p.o
  CC       globfree.o
  CC       localtime-buffer.o
In file included from ../../../../binutils-gdb/gdb/gnulib/import/scratch_buffer.h:9:0,
                 from ../../../../binutils-gdb/gdb/gnulib/import/glob.c:87:
../../../../binutils-gdb/gdb/gnulib/import/malloc/scratch_buffer.h:69:3: error: unknown type name max_align_t
   max_align_t __space[(1023 + sizeof (max_align_t)) / sizeof (max_align_t)];
   ^
../../../../binutils-gdb/gdb/gnulib/import/malloc/scratch_buffer.h:69:39: error: max_align_t undeclared here (not in a function)
   max_align_t __space[(1023 + sizeof (max_align_t)) / sizeof (max_align_t)];
                                       ^
../../../../binutils-gdb/gdb/gnulib/import/glob.c: In function glob_in_dir:
../../../../binutils-gdb/gdb/gnulib/import/glob.c:1413:15: error: for loop initial declarations are only allowed in C99 mode
               for (size_t i = 0; i < cur; ++i)
               ^
../../../../binutils-gdb/gdb/gnulib/import/glob.c:1413:15: note: use option -std=c99 or -std=gnu99 to compile your code
../../../../binutils-gdb/gdb/gnulib/import/glob.c:1438:15: error: for loop initial declarations are only allowed in C99 mode
               for (size_t i = 0; i < cur; ++i)
               ^
make[8]: *** [glob.o] Error 1
make[8]: *** Waiting for unfinished jobs....
  CC       mbrtowc.o
make[8]: Leaving directory `/home/dje/rhel-7_1-s390x-1/rhel-s390x/build/gdb/build-gnulib/import'
make[7]: *** [all-recursive] Error 1
make[7]: Leaving directory `/home/dje/rhel-7_1-s390x-1/rhel-s390x/build/gdb/build-gnulib/import'
make[6]: *** [all] Error 2
make[6]: Leaving directory `/home/dje/rhel-7_1-s390x-1/rhel-s390x/build/gdb/build-gnulib/import'
make[5]: *** [subdir_do] Error 1
make[5]: Leaving directory `/home/dje/rhel-7_1-s390x-1/rhel-s390x/build/gdb/build-gnulib'
make[4]: *** [all] Error 2
make[4]: Leaving directory `/home/dje/rhel-7_1-s390x-1/rhel-s390x/build/gdb/build-gnulib'
make[3]: *** [subdir_do] Error 1
make[3]: Leaving directory `/home/dje/rhel-7_1-s390x-1/rhel-s390x/build/gdb'
make[2]: *** [all-lib] Error 2
make[2]: Leaving directory `/home/dje/rhel-7_1-s390x-1/rhel-s390x/build/gdb'
make[1]: *** [all-gdb] Error 2
make[1]: Leaving directory `/home/dje/rhel-7_1-s390x-1/rhel-s390x/build'
make: *** [all] Error 2
============================

Re: Oh dear. I regret to inform you that commit 23c4651c060c123493de004ef61d8ed052d46113 might be unfortunate

[Eli Zaretskii]

> From: gdb-buildbot@sergiodj.net
> Date: Mon, 10 Sep 2018 03:19:34 -0400
> 
> My lords, ladies, gentlemen, members of the public.
> 
> It is a matter of great regret and sadness to inform you that commit:
> 
> 	Fix "make install-strip" failure to install gdb-add-index.sh
> 	23c4651c060c123493de004ef61d8ed052d46113
> 
> might have made GDB unwell.  Since I am just your Butler BuildBot,
> I kindly ask that a human superior officer double-check this.

It is clear from the build log that the breakage has nothing to do
with the change I committed.  In particular, the offending parts of
gnulib's glob.c were not modified by my commit, but by Sergio's commit
7a6dbc2 of 2 weeks ago.  Why is this being flagged only now?

Re: Oh dear. I regret to inform you that commit 23c4651c060c123493de004ef61d8ed052d46113 might be unfortunate

[Tom Tromey]

Eli> It is clear from the build log that the breakage has nothing to do
Eli> with the change I committed.  In particular, the offending parts of
Eli> gnulib's glob.c were not modified by my commit, but by Sergio's commit
Eli> 7a6dbc2 of 2 weeks ago.  Why is this being flagged only now?

I think it complains on each commit.  Sergio was out last week IIRC and
then there was the Cauldron, so the fix for this is lagging a little.
But I think it should come soon.

Tom

Re: Oh dear. I regret to inform you that commit 23c4651c060c123493de004ef61d8ed052d46113 might be unfortunate

[Sergio Durigan Junior]

On Monday, September 10 2018, Eli Zaretskii wrote:

>> From: gdb-buildbot@sergiodj.net
>> Date: Mon, 10 Sep 2018 03:19:34 -0400
>> 
>> My lords, ladies, gentlemen, members of the public.
>> 
>> It is a matter of great regret and sadness to inform you that commit:
>> 
>> 	Fix "make install-strip" failure to install gdb-add-index.sh
>> 	23c4651c060c123493de004ef61d8ed052d46113
>> 
>> might have made GDB unwell.  Since I am just your Butler BuildBot,
>> I kindly ask that a human superior officer double-check this.
>
> It is clear from the build log that the breakage has nothing to do
> with the change I committed.  In particular, the offending parts of
> gnulib's glob.c were not modified by my commit, but by Sergio's commit
> 7a6dbc2 of 2 weeks ago.  Why is this being flagged only now?

Hi Eli,

There must have been some problem with the locking mechanism which
prevents the BuildBot from flagging the same breakage many times.  Sorry
about that.  Also, a few of the buildslaves are lagging behind and
having a hard time keeping up with the builds.  Anyway, I'm back to work
today and will submit a patch to fix this failure soon.

Thanks for the patience,

-- 
Sergio
GPG key ID: 237A 54B1 0287 28BF 00EF  31F4 D0EB 7628 65FC 5E36
Please send encrypted e-mail if possible
http://sergiodj.net/