[PATCH] gdbarch-components.py: change empty "params" tuples to empty lists

[PATCH] gdbarch-components.py: change empty "params" tuples to empty lists

[Simon Marchi via Gdb-patches]

During review, it was suggested to change the "params" parameter from a
tuple to a list, for esthetic reasons.  The empty ones are still tuples
though, they should probably be changed to be empty lists, for
consistency.  It does not change anything in the script result.

Change-Id: If13c6c527aa167a5ee5b45740e5f1bda1e9517e4
---
 gdb/gdbarch-components.py | 16 ++++++++--------
 1 file changed, 8 insertions(+), 8 deletions(-)

diff --git a/gdb/gdbarch-components.py b/gdb/gdbarch-components.py
index a5c3c38147fe..94a684cecc80 100644
--- a/gdb/gdbarch-components.py
+++ b/gdb/gdbarch-components.py
@@ -1688,7 +1688,7 @@ gdbarch_software_single_step routine, and true otherwise.
 """,
     type="bool",
     name="displaced_step_hw_singlestep",
-    params=(),
+    params=[],
     predefault="default_displaced_step_hw_singlestep",
     invalid=False,
 )
@@ -1890,7 +1890,7 @@ Return a type suitable to inspect extra signal information.
 """,
     type="struct type *",
     name="get_siginfo_type",
-    params=(),
+    params=[],
     predicate=True,
     invalid=True,
 )
@@ -2236,7 +2236,7 @@ True if inferiors share an address space (e.g., uClinux).
 """,
     type="int",
     name="has_shared_address_space",
-    params=(),
+    params=[],
     predefault="default_has_shared_address_space",
     invalid=False,
 )
@@ -2272,7 +2272,7 @@ Return the "auto" target charset.
 """,
     type="const char *",
     name="auto_charset",
-    params=(),
+    params=[],
     predefault="default_auto_charset",
     invalid=False,
 )
@@ -2283,7 +2283,7 @@ Return the "auto" target wide charset.
 """,
     type="const char *",
     name="auto_wide_charset",
-    params=(),
+    params=[],
     predefault="default_auto_wide_charset",
     invalid=False,
 )
@@ -2520,7 +2520,7 @@ they can override it.
 """,
     type="std::string",
     name="gcc_target_options",
-    params=(),
+    params=[],
     predefault="default_gcc_target_options",
     invalid=False,
 )
@@ -2535,7 +2535,7 @@ case.
 """,
     type="const char *",
     name="gnu_triplet_regexp",
-    params=(),
+    params=[],
     predefault="default_gnu_triplet_regexp",
     invalid=False,
 )
@@ -2548,7 +2548,7 @@ each address in memory.
 """,
     type="int",
     name="addressable_memory_unit_size",
-    params=(),
+    params=[],
     predefault="default_addressable_memory_unit_size",
     invalid=False,
 )
-- 
2.34.1

Re: [PATCH] gdbarch-components.py: change empty "params" tuples to empty lists

[Tom Tromey]

>>>>> "Simon" == Simon Marchi via Gdb-patches <gdb-patches@sourceware.org> writes:

Simon> During review, it was suggested to change the "params" parameter from a
Simon> tuple to a list, for esthetic reasons.  The empty ones are still tuples
Simon> though, they should probably be changed to be empty lists, for
Simon> consistency.

Oops, I missed that.  This looks fine to me.

Tom

Re: [PATCH] gdbarch-components.py: change empty "params" tuples to empty lists

[Simon Marchi via Gdb-patches]

On 2021-12-21 17:39, Tom Tromey wrote:
>>>>>> "Simon" == Simon Marchi via Gdb-patches <gdb-patches@sourceware.org> writes:
> 
> Simon> During review, it was suggested to change the "params" parameter from a
> Simon> tuple to a list, for esthetic reasons.  The empty ones are still tuples
> Simon> though, they should probably be changed to be empty lists, for
> Simon> consistency.
> 
> Oops, I missed that.  This looks fine to me.
> 
> Tom

Thanks, pushed.

Simon