From: Tom Tromey <tom@tromey.com>
To: Keith Seitz <keiths@redhat.com>
Cc: Guinevere Larsen <guinevere@redhat.com>, gdb-patches@sourceware.org
Subject: Re: [PATCH] gdb/testsuite: rework bp-cond-failure to not depend on inlining
Date: Fri, 20 Sep 2024 12:55:25 -0600 [thread overview]
Message-ID: <87setunoiq.fsf@tromey.com> (raw)
In-Reply-To: <cdb57aa0-337b-42a7-b96a-25f336a6a17e@redhat.com> (Keith Seitz's message of "Fri, 20 Sep 2024 09:45:59 -0700")
>>>>> "Keith" == Keith Seitz <keiths@redhat.com> writes:
Keith> On 9/20/24 9:20 AM, Guinevere Larsen wrote:
>> I've given some more thought and I think a couple of comments could
>> help anyway. Here's my suggestion, thought?
Keith> I am pleased to have an explanation there. Thank you!
FWIW I read through this and it all seems fine to me as well.
Thanks for your review Keith.
Approved-By: Tom Tromey <tom@tromey.com>
Tom
next prev parent reply other threads:[~2024-09-20 18:55 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-09-19 12:42 Guinevere Larsen
2024-09-20 15:35 ` Keith Seitz
2024-09-20 15:56 ` Guinevere Larsen
2024-09-20 15:58 ` Keith Seitz
2024-09-20 16:20 ` Guinevere Larsen
2024-09-20 16:45 ` Keith Seitz
2024-09-20 18:55 ` Tom Tromey [this message]
2024-09-20 19:11 ` Guinevere Larsen
2024-09-23 7:46 ` Aktemur, Tankut Baris
2024-09-23 10:40 ` Andrew Burgess
2024-09-23 12:24 ` Aktemur, Tankut Baris
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87setunoiq.fsf@tromey.com \
--to=tom@tromey.com \
--cc=gdb-patches@sourceware.org \
--cc=guinevere@redhat.com \
--cc=keiths@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox