From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id wNkmEjPF7WYonzEAWB0awg (envelope-from ) for ; Fri, 20 Sep 2024 14:55:47 -0400 Authentication-Results: simark.ca; dkim=fail reason="signature verification failed" (768-bit key; unprotected) header.d=tromey.com header.i=@tromey.com header.a=rsa-sha256 header.s=default header.b=Hs6+5YGm; dkim-atps=neutral Received: by simark.ca (Postfix, from userid 112) id 42E801E353; Fri, 20 Sep 2024 14:55:47 -0400 (EDT) X-Spam-Checker-Version: SpamAssassin 4.0.0 (2022-12-13) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-11.5 required=5.0 tests=ARC_SIGNED,ARC_VALID, BAYES_00,DKIM_INVALID,DKIM_SIGNED,MAILING_LIST_MULTI,RCVD_IN_DNSWL_HI, RCVD_IN_VALIDITY_CERTIFIED,RCVD_IN_VALIDITY_RPBL,RCVD_IN_VALIDITY_SAFE, URIBL_BLOCKED,URIBL_DBL_BLOCKED_OPENDNS autolearn=ham autolearn_force=no version=4.0.0 Received: from server2.sourceware.org (server2.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 959701E08F for ; Fri, 20 Sep 2024 14:55:46 -0400 (EDT) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 4F1683857C4F for ; Fri, 20 Sep 2024 18:55:46 +0000 (GMT) Received: from omta40.uswest2.a.cloudfilter.net (omta40.uswest2.a.cloudfilter.net [35.89.44.39]) by sourceware.org (Postfix) with ESMTPS id 57F7B3858D39 for ; Fri, 20 Sep 2024 18:55:28 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 57F7B3858D39 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=tromey.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=tromey.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 57F7B3858D39 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=35.89.44.39 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1726858529; cv=none; b=wOBhNU4cHN+piYxLBgzJEJNKJkCL8h0lQaErWsgDPl2NKc7Swyubg1sxlvHHVLTfStGhXACwppFwm+odD7g7lAG19Kla5ikKVnv28oU2jBW96bCw+ILokRLAf3tHtkd2iAD9gtMZ5GmCLlteuQIxL4c72Zjv+T8a1YR4ntDT0U8= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1726858529; c=relaxed/simple; bh=7Tof2m+SHQAqSBAUqifDCuJ8KDFb506AIkITY3lh+q8=; h=DKIM-Signature:From:To:Subject:Date:Message-ID:MIME-Version; b=QsvkXJdLw0Unpzlk7mnEGIGhp/iBlTuGsa/r1sF4QYsaYKhm+2VigCLOG0e5BxazE2g+Z3iVlDyzuRbNn0/p1rEzkYrq6RF5K1MWTZ7SfvyQjjGQytxrM4WqTEwnEUFmf3jPDvjFIDmwdwIpfAJSkhCt6BAfTAsTD5OFjzIPrWA= ARC-Authentication-Results: i=1; server2.sourceware.org Received: from eig-obgw-5004a.ext.cloudfilter.net ([10.0.29.221]) by cmsmtp with ESMTPS id rglFsmAJOvH7lrimusoXpx; Fri, 20 Sep 2024 18:55:28 +0000 Received: from box5379.bluehost.com ([162.241.216.53]) by cmsmtp with ESMTPS id rimss4iWN0vWTrimtsp3Hd; Fri, 20 Sep 2024 18:55:27 +0000 X-Authority-Analysis: v=2.4 cv=ffZmyFQF c=1 sm=1 tr=0 ts=66edc51f a=ApxJNpeYhEAb1aAlGBBbmA==:117 a=ApxJNpeYhEAb1aAlGBBbmA==:17 a=EaEq8P2WXUwA:10 a=ItBw4LHWJt0A:10 a=20KFwNOVAAAA:8 a=zstS-IiYAAAA:8 a=wlXlsamvc8aK3keghoEA:9 a=4G6NA9xxw8l3yy4pmD5M:22 a=6Ogn3jAGHLSNbaov7Orx:22 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=tromey.com; s=default; h=Content-Type:MIME-Version:Message-ID:Date:References:In-Reply-To :Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=7Tof2m+SHQAqSBAUqifDCuJ8KDFb506AIkITY3lh+q8=; b=Hs6+5YGmwJ/l7KOq7siDJv5Ru0 WQR4coH7YmAj1zmEJBdFqdycRAK0FZbse1uE6fhEri2zDZs2kPnVAGOTGJVgX/Fq1nHxSkE23zAHX Uu1TXvRnmsu3M5Qb691WrmBBz; Received: from 97-118-34-56.hlrn.qwest.net ([97.118.34.56]:36938 helo=murgatroyd) by box5379.bluehost.com with esmtpsa (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.96.2) (envelope-from ) id 1srims-002zgT-1b; Fri, 20 Sep 2024 12:55:26 -0600 From: Tom Tromey To: Keith Seitz Cc: Guinevere Larsen , gdb-patches@sourceware.org Subject: Re: [PATCH] gdb/testsuite: rework bp-cond-failure to not depend on inlining In-Reply-To: (Keith Seitz's message of "Fri, 20 Sep 2024 09:45:59 -0700") References: <20240919124204.1465834-1-blarsen@redhat.com> <1940030f-122d-4656-a293-44e5b5a98c92@redhat.com> X-Attribution: Tom Date: Fri, 20 Sep 2024 12:55:25 -0600 Message-ID: <87setunoiq.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - box5379.bluehost.com X-AntiAbuse: Original Domain - sourceware.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - tromey.com X-BWhitelist: no X-Source-IP: 97.118.34.56 X-Source-L: No X-Exim-ID: 1srims-002zgT-1b X-Source: X-Source-Args: X-Source-Dir: X-Source-Sender: 97-118-34-56.hlrn.qwest.net (murgatroyd) [97.118.34.56]:36938 X-Source-Auth: tom+tromey.com X-Email-Count: 11 X-Org: HG=bhshared;ORG=bluehost; X-Source-Cap: ZWx5bnJvYmk7ZWx5bnJvYmk7Ym94NTM3OS5ibHVlaG9zdC5jb20= X-Local-Domain: yes X-CMAE-Envelope: MS4xfHHTyveuPRVzl34HLb4SEvJDjoKReCVVfIO0536AXzKH4VGNQcU4F5eT8/hc9QCoazRQBfwWh2Jb9kVYsD/J3uEJe9EbJoccGs0tCla+R2uHOl9yWbTm EzlxHMJ5lT11A27jKQLiO0VGu1M1oMsZHkybcnRgzFYw3kP2UV2t9Ag/RFfXGHdwZDzm7h19S2pWHhhfAJD4AIJd6nQvbD/q/EM= X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces~public-inbox=simark.ca@sourceware.org >>>>> "Keith" == Keith Seitz writes: Keith> On 9/20/24 9:20 AM, Guinevere Larsen wrote: >> I've given some more thought and I think a couple of comments could >> help anyway. Here's my suggestion, thought? Keith> I am pleased to have an explanation there. Thank you! FWIW I read through this and it all seems fine to me as well. Thanks for your review Keith. Approved-By: Tom Tromey Tom