From: Tom Tromey <tromey@redhat.com>
To: Michael Eager <eager@eagerm.com>
Cc: "gdb-patches\@sourceware.org" <gdb-patches@sourceware.org>
Subject: Re: [PATCH] PR14291: KeyboardInterrupt not caught for Python output
Date: Wed, 27 Jun 2012 13:37:00 -0000 [thread overview]
Message-ID: <87r4t098qi.fsf@fleche.redhat.com> (raw)
In-Reply-To: <4FE85A77.70809@eagerm.com> (Michael Eager's message of "Mon, 25 Jun 2012 05:32:55 -0700")
>>>>> "Michael" == Michael Eager <eager@eagerm.com> writes:
Michael> 2012-06-25 Michael Eager <eager@eagercon.com>
Michael> * python/python.c (gdbpy_write): Check for interrupted
Michael> output.
This caused a regression:
FAIL: gdb.python/python.exp: verify pagination beforehand: q
FAIL: gdb.python/python.exp: verify pagination afterwards: q
I'm checking in the appended.
It just updates the regexps to match what is printed.
Tom
2012-06-27 Tom Tromey <tromey@redhat.com>
* gdb.python/python.exp: Fix regexps in pagination tests.
Index: gdb.python/python.exp
===================================================================
RCS file: /cvs/src/src/gdb/testsuite/gdb.python/python.exp,v
retrieving revision 1.34
diff -u -r1.34 python.exp
--- gdb.python/python.exp 22 Jun 2012 17:59:33 -0000 1.34
+++ gdb.python/python.exp 27 Jun 2012 13:35:24 -0000
@@ -112,7 +112,7 @@
pass $test
}
}
-gdb_test "q" "Quit" "verify pagination beforehand: q"
+gdb_test "q" "Quit.*Error while executing Python.*" "verify pagination beforehand: q"
gdb_test "python if gdb.execute('python print \"\\\\n\" * $lines', to_string=True) == \"\\n\" * [expr $lines + 1]: print \"yes\"" "yes" "gdb.execute does not page"
@@ -128,7 +128,7 @@
pass $test
}
}
-gdb_test "q" "Quit" "verify pagination afterwards: q"
+gdb_test "q" "Quit.*Error while executing Python.*" "verify pagination afterwards: q"
gdb_test_no_output "set height 0"
next prev parent reply other threads:[~2012-06-27 13:37 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-06-25 12:33 Michael Eager
2012-06-25 15:26 ` Tom Tromey
2012-06-25 16:54 ` Michael Eager
2012-06-27 13:37 ` Tom Tromey [this message]
2012-06-27 14:06 ` Michael Eager
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87r4t098qi.fsf@fleche.redhat.com \
--to=tromey@redhat.com \
--cc=eager@eagerm.com \
--cc=gdb-patches@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox