From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 17789 invoked by alias); 27 Jun 2012 13:37:30 -0000 Received: (qmail 17355 invoked by uid 22791); 27 Jun 2012 13:37:28 -0000 X-SWARE-Spam-Status: No, hits=-6.5 required=5.0 tests=AWL,BAYES_00,KHOP_RCVD_UNTRUST,RCVD_IN_DNSWL_HI,RCVD_IN_HOSTKARMA_W,SPF_HELO_PASS,T_RP_MATCHES_RCVD X-Spam-Check-By: sourceware.org Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Wed, 27 Jun 2012 13:37:11 +0000 Received: from int-mx01.intmail.prod.int.phx2.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id q5RDbAXY003138 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Wed, 27 Jun 2012 09:37:10 -0400 Received: from barimba (ovpn01.gateway.prod.ext.phx2.redhat.com [10.5.9.1]) by int-mx01.intmail.prod.int.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id q5RDb9Ok022624 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES128-SHA bits=128 verify=NO); Wed, 27 Jun 2012 09:37:09 -0400 From: Tom Tromey To: Michael Eager Cc: "gdb-patches\@sourceware.org" Subject: Re: [PATCH] PR14291: KeyboardInterrupt not caught for Python output References: <4FE85A77.70809@eagerm.com> Date: Wed, 27 Jun 2012 13:37:00 -0000 In-Reply-To: <4FE85A77.70809@eagerm.com> (Michael Eager's message of "Mon, 25 Jun 2012 05:32:55 -0700") Message-ID: <87r4t098qi.fsf@fleche.redhat.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2012-06/txt/msg00829.txt.bz2 >>>>> "Michael" == Michael Eager writes: Michael> 2012-06-25 Michael Eager Michael> * python/python.c (gdbpy_write): Check for interrupted Michael> output. This caused a regression: FAIL: gdb.python/python.exp: verify pagination beforehand: q FAIL: gdb.python/python.exp: verify pagination afterwards: q I'm checking in the appended. It just updates the regexps to match what is printed. Tom 2012-06-27 Tom Tromey * gdb.python/python.exp: Fix regexps in pagination tests. Index: gdb.python/python.exp =================================================================== RCS file: /cvs/src/src/gdb/testsuite/gdb.python/python.exp,v retrieving revision 1.34 diff -u -r1.34 python.exp --- gdb.python/python.exp 22 Jun 2012 17:59:33 -0000 1.34 +++ gdb.python/python.exp 27 Jun 2012 13:35:24 -0000 @@ -112,7 +112,7 @@ pass $test } } -gdb_test "q" "Quit" "verify pagination beforehand: q" +gdb_test "q" "Quit.*Error while executing Python.*" "verify pagination beforehand: q" gdb_test "python if gdb.execute('python print \"\\\\n\" * $lines', to_string=True) == \"\\n\" * [expr $lines + 1]: print \"yes\"" "yes" "gdb.execute does not page" @@ -128,7 +128,7 @@ pass $test } } -gdb_test "q" "Quit" "verify pagination afterwards: q" +gdb_test "q" "Quit.*Error while executing Python.*" "verify pagination afterwards: q" gdb_test_no_output "set height 0"