From: Tom Tromey <tromey@redhat.com>
To: Joel Brobecker <brobecker@adacore.com>
Cc: gdb-patches@sourceware.org
Subject: Re: [RFA] DWARF frame unwinder executes one too many rows
Date: Mon, 30 Jul 2012 17:43:00 -0000 [thread overview]
Message-ID: <87r4rt2lhk.fsf@fleche.redhat.com> (raw)
In-Reply-To: <1343343082-15401-1-git-send-email-brobecker@adacore.com> (Joel Brobecker's message of "Thu, 26 Jul 2012 15:51:22 -0700")
>>>>> "Joel" == Joel Brobecker <brobecker@adacore.com> writes:
Joel> gdb/ChangeLog:
Joel> * dwarf2-frame.c (dwarf2_frame_cache): Use
Joel> get_frame_address_in_block instead of get_frame_pc as
Joel> the bound for executing the frame's FDE.
Joel> gdb/testsuite/ChangeLog:
Joel> * gdb.ada/rdv_wait: New testcase.
This looks good to me.
I looked into the history a tiny bit. It appears I introduced this in
revision 1.120, but looking at the diff it appears I just hoisted the
call to get_frame_pc out of execute_cfa_program. Whew.
Before that it gets into stuff before my involvement:
- CORE_ADDR pc = frame_pc_unwind (next_frame);
+ CORE_ADDR pc = get_frame_pc (this_frame);
Tom
next prev parent reply other threads:[~2012-07-30 17:43 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-07-26 22:51 Joel Brobecker
2012-07-27 11:07 ` asmwarrior
2012-07-27 11:15 ` asmwarrior
2012-07-27 12:14 ` Joel Brobecker
2012-07-30 17:43 ` Tom Tromey [this message]
2012-08-16 15:47 ` Joel Brobecker
2012-08-04 12:30 ` Jan Kratochvil
2012-08-06 14:05 ` Tom Tromey
2012-08-06 15:06 ` Jan Kratochvil
2012-08-06 15:10 ` Tom Tromey
2012-08-06 15:19 ` Jan Kratochvil
2012-08-17 18:14 ` [patch] testsuite: Test the unwinder off-by-one [Re: [RFA] DWARF frame unwinder executes one too many rows] Jan Kratochvil
2012-08-27 16:35 ` [commit] " Jan Kratochvil
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87r4rt2lhk.fsf@fleche.redhat.com \
--to=tromey@redhat.com \
--cc=brobecker@adacore.com \
--cc=gdb-patches@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox