From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 17244 invoked by alias); 30 Jul 2012 17:43:59 -0000 Received: (qmail 17235 invoked by uid 22791); 30 Jul 2012 17:43:58 -0000 X-SWARE-Spam-Status: No, hits=-6.5 required=5.0 tests=AWL,BAYES_00,KHOP_RCVD_UNTRUST,RCVD_IN_DNSWL_HI,RCVD_IN_HOSTKARMA_W,SPF_HELO_PASS,T_RP_MATCHES_RCVD X-Spam-Check-By: sourceware.org Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Mon, 30 Jul 2012 17:43:44 +0000 Received: from int-mx12.intmail.prod.int.phx2.redhat.com (int-mx12.intmail.prod.int.phx2.redhat.com [10.5.11.25]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id q6UHhK6o026161 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Mon, 30 Jul 2012 13:43:21 -0400 Received: from barimba (ovpn01.gateway.prod.ext.phx2.redhat.com [10.5.9.1]) by int-mx12.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id q6UHhJ4j000825 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES128-SHA bits=128 verify=NO); Mon, 30 Jul 2012 13:43:19 -0400 From: Tom Tromey To: Joel Brobecker Cc: gdb-patches@sourceware.org Subject: Re: [RFA] DWARF frame unwinder executes one too many rows References: <1343343082-15401-1-git-send-email-brobecker@adacore.com> Date: Mon, 30 Jul 2012 17:43:00 -0000 In-Reply-To: <1343343082-15401-1-git-send-email-brobecker@adacore.com> (Joel Brobecker's message of "Thu, 26 Jul 2012 15:51:22 -0700") Message-ID: <87r4rt2lhk.fsf@fleche.redhat.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2012-07/txt/msg00770.txt.bz2 >>>>> "Joel" == Joel Brobecker writes: Joel> gdb/ChangeLog: Joel> * dwarf2-frame.c (dwarf2_frame_cache): Use Joel> get_frame_address_in_block instead of get_frame_pc as Joel> the bound for executing the frame's FDE. Joel> gdb/testsuite/ChangeLog: Joel> * gdb.ada/rdv_wait: New testcase. This looks good to me. I looked into the history a tiny bit. It appears I introduced this in revision 1.120, but looking at the diff it appears I just hoisted the call to get_frame_pc out of execute_cfa_program. Whew. Before that it gets into stuff before my involvement: - CORE_ADDR pc = frame_pc_unwind (next_frame); + CORE_ADDR pc = get_frame_pc (this_frame); Tom