* [PATCH 3/3] gdb/testsuite/gdb.cp/annota2.exp: Add missing empty line, in output.
@ 2013-06-05 10:34 Will Newton
2013-06-05 15:49 ` Tom Tromey
0 siblings, 1 reply; 6+ messages in thread
From: Will Newton @ 2013-06-05 10:34 UTC (permalink / raw)
To: gdb-patches; +Cc: patches
There should be an empty line between "post-prompt" and "starting".
This fixes a testsuite failure on ARM.
gdb/testsuite/ChangeLog:
2013-06-05 Will Newton <will.newton@linaro.org>
* gdb.cp/annota2.exp: Add empty line between "post-prompt"
and "starting".
---
gdb/testsuite/gdb.cp/annota2.exp | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/gdb/testsuite/gdb.cp/annota2.exp b/gdb/testsuite/gdb.cp/annota2.exp
index d0a457a..0c17947 100644
--- a/gdb/testsuite/gdb.cp/annota2.exp
+++ b/gdb/testsuite/gdb.cp/annota2.exp
@@ -162,7 +162,7 @@ gdb_test_multiple "watch a.x" "set watch on a.x" {
# annotate-watchpoint
#
gdb_test_multiple "next" "watch triggered on a.x" {
- -re "\r\n\032\032post-prompt\r\n\032\032starting\r\n${frames_invalid}${breakpoints_invalid}\r\n\032\032watchpoint 3\r\n.*atchpoint 3: a.x\r\n\r\nOld value = 0\r\nNew value = 1\r\n\r\n\032\032frame-begin 0 $hex\r\n\r\n\032\032frame-function-name\r\nmain\r\n\032\032frame-args\r\n \\(\\)\r\n\032\032frame-source-begin\r\n at \r\n\032\032frame-source-file\r\n.*$srcfile\r\n\032\032frame-source-file-end\r\n:\r\n\032\032frame-source-line\r\n$decimal\r\n\032\032frame-source-end\r\n\r\n\r\n\032\032source .*$srcfile.*beg:$hex\r\n\r\n\032\032frame-end\r\n\r\n\032\032stopped\r\n.*$gdb_prompt$" {
+ -re "\r\n\032\032post-prompt\r\n\r\n\032\032starting\r\n${frames_invalid}${breakpoints_invalid}\r\n\032\032watchpoint 3\r\n.*atchpoint 3: a.x\r\n\r\nOld value = 0\r\nNew value = 1\r\n\r\n\032\032frame-begin 0 $hex\r\n\r\n\032\032frame-function-name\r\nmain\r\n\032\032frame-args\r\n \\(\\)\r\n\032\032frame-source-begin\r\n at \r\n\032\032frame-source-file\r\n.*$srcfile\r\n\032\032frame-source-file-end\r\n:\r\n\032\032frame-source-line\r\n$decimal\r\n\032\032frame-source-end\r\n\r\n\r\n\032\032source .*$srcfile.*beg:$hex\r\n\r\n\032\032frame-end\r\n\r\n\032\032stopped\r\n.*$gdb_prompt$" {
pass "watch triggered on a.x"
}
-re "\r\n\032\032post-prompt\r\n\r\n\032\032starting\r\n${frames_invalid}\r\n\032\032source .*$srcfile.*beg:$hex\r\n\r\n\032\032frame-end\r\n\r\n\032\032stopped\r\n$gdb_prompt$" {
--
1.8.1.4
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH 3/3] gdb/testsuite/gdb.cp/annota2.exp: Add missing empty line, in output.
2013-06-05 10:34 [PATCH 3/3] gdb/testsuite/gdb.cp/annota2.exp: Add missing empty line, in output Will Newton
@ 2013-06-05 15:49 ` Tom Tromey
2013-06-05 17:48 ` Will Newton
0 siblings, 1 reply; 6+ messages in thread
From: Tom Tromey @ 2013-06-05 15:49 UTC (permalink / raw)
To: Will Newton; +Cc: gdb-patches, patches
>>>>> "Will" == Will Newton <will.newton@linaro.org> writes:
Will> There should be an empty line between "post-prompt" and "starting".
Will> This fixes a testsuite failure on ARM.
Will> gdb/testsuite/ChangeLog:
Will> 2013-06-05 Will Newton <will.newton@linaro.org>
Will> * gdb.cp/annota2.exp: Add empty line between "post-prompt"
Will> and "starting".
This is ok.
This test still KFAILs for me, on x86-64 F18.
It seems that the watchpoint doesn't actually trigger.
Tom
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH 3/3] gdb/testsuite/gdb.cp/annota2.exp: Add missing empty line, in output.
2013-06-05 15:49 ` Tom Tromey
@ 2013-06-05 17:48 ` Will Newton
2013-06-05 19:19 ` Tom Tromey
0 siblings, 1 reply; 6+ messages in thread
From: Will Newton @ 2013-06-05 17:48 UTC (permalink / raw)
To: Tom Tromey; +Cc: gdb-patches, Patch Tracking
On 5 June 2013 16:48, Tom Tromey <tromey@redhat.com> wrote:
>>>>>> "Will" == Will Newton <will.newton@linaro.org> writes:
>
> Will> There should be an empty line between "post-prompt" and "starting".
> Will> This fixes a testsuite failure on ARM.
>
> Will> gdb/testsuite/ChangeLog:
>
> Will> 2013-06-05 Will Newton <will.newton@linaro.org>
>
> Will> * gdb.cp/annota2.exp: Add empty line between "post-prompt"
> Will> and "starting".
>
> This is ok.
>
> This test still KFAILs for me, on x86-64 F18.
> It seems that the watchpoint doesn't actually trigger.
I get a KFAIL on x86_64 also, but on ARM prior to this change I would
get a timeout.
I can commit to binutils but not have not committed to gdb thus far.
--
Will Newton
Toolchain Working Group, Linaro
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH 3/3] gdb/testsuite/gdb.cp/annota2.exp: Add missing empty line, in output.
2013-06-05 17:48 ` Will Newton
@ 2013-06-05 19:19 ` Tom Tromey
2013-06-06 9:04 ` Will Newton
0 siblings, 1 reply; 6+ messages in thread
From: Tom Tromey @ 2013-06-05 19:19 UTC (permalink / raw)
To: Will Newton; +Cc: gdb-patches, Patch Tracking
Will> I can commit to binutils but not have not committed to gdb thus far.
Do you have the necessary paperwork in place for gdb?
You are in the correct group on sourceware, because gdb and binutils
share a repository.
Tom
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH 3/3] gdb/testsuite/gdb.cp/annota2.exp: Add missing empty line, in output.
2013-06-05 19:19 ` Tom Tromey
@ 2013-06-06 9:04 ` Will Newton
2013-06-06 10:33 ` Pedro Alves
0 siblings, 1 reply; 6+ messages in thread
From: Will Newton @ 2013-06-06 9:04 UTC (permalink / raw)
To: Tom Tromey; +Cc: gdb-patches, Patch Tracking
On 5 June 2013 20:19, Tom Tromey <tromey@redhat.com> wrote:
> Will> I can commit to binutils but not have not committed to gdb thus far.
>
> Do you have the necessary paperwork in place for gdb?
I believe it is covered by the Linaro assignment.
> You are in the correct group on sourceware, because gdb and binutils
> share a repository.
I'm happy to commit the changes myself, I just wanted to make sure it
was ok before going ahead.
--
Will Newton
Toolchain Working Group, Linaro
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH 3/3] gdb/testsuite/gdb.cp/annota2.exp: Add missing empty line, in output.
2013-06-06 9:04 ` Will Newton
@ 2013-06-06 10:33 ` Pedro Alves
0 siblings, 0 replies; 6+ messages in thread
From: Pedro Alves @ 2013-06-06 10:33 UTC (permalink / raw)
To: Will Newton; +Cc: Tom Tromey, gdb-patches, Patch Tracking
On 06/06/2013 10:04 AM, Will Newton wrote:
> On 5 June 2013 20:19, Tom Tromey <tromey@redhat.com> wrote:
>> Will> I can commit to binutils but not have not committed to gdb thus far.
>>
>> Do you have the necessary paperwork in place for gdb?
>
> I believe it is covered by the Linaro assignment.
Confirmed. Linaro has blanket assignment for GDB covering all employees.
>
>> You are in the correct group on sourceware, because gdb and binutils
>> share a repository.
>
> I'm happy to commit the changes myself, I just wanted to make sure it
> was ok before going ahead.
Could you please commit (and post) a patch adding yourself to
Write After Approval in gdb/MAINTAINERS?
Thanks!
--
Pedro Alves
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2013-06-06 10:33 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2013-06-05 10:34 [PATCH 3/3] gdb/testsuite/gdb.cp/annota2.exp: Add missing empty line, in output Will Newton
2013-06-05 15:49 ` Tom Tromey
2013-06-05 17:48 ` Will Newton
2013-06-05 19:19 ` Tom Tromey
2013-06-06 9:04 ` Will Newton
2013-06-06 10:33 ` Pedro Alves
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox