From: Tom Tromey <tom@tromey.com>
To: Manish Goregaokar <manish@mozilla.com>
Cc: gdb-patches@sourceware.org, Tom Tromey <tom@tromey.com>
Subject: Re: [PATCH 2/2][PR gdb/20239] Add tests for printing of NonZero-optimized enums in Rust
Date: Wed, 22 Jun 2016 19:11:00 -0000 [thread overview]
Message-ID: <87r3bpjaxo.fsf@tromey.com> (raw)
In-Reply-To: <CAFOnWkmnZbnZ0VV6tiOOz+8rxCDokx0cTv8ojZ1Q6mCxGLrfCQ@mail.gmail.com> (Manish Goregaokar's message of "Tue, 21 Jun 2016 15:11:52 +0530")
>>>>> "Manish" == Manish Goregaokar <manish@mozilla.com> writes:
Manish> Continuing discussion from
Manish> https://sourceware.org/bugzilla/show_bug.cgi?id=20239, I'm not sure if
Manish> it's worth it to have a test that inspects the entire output, since
Manish> the internals of the String type may change in the future. Did you
Manish> mean something else?
Actually it just wasn't clear to me if the test case in question was "as
complicated" as the code inspiring the original report. But it probably
doesn't matter.
Manish> gdb/testsuite/ChangeLog:
Manish> 2016-06-21 Manish Goregaokar <manish@mozilla.com>
Manish> PR gdb/20239
Manish> * gdb.rust/simple.rs: Add more tests for printing NonZero enums.
Manish> * gdb.rust/simple.exp: Add test expectations for new NonZero tests.
Thank you. This patch is ok.
Tom
prev parent reply other threads:[~2016-06-22 19:11 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-06-21 9:42 Manish Goregaokar
2016-06-22 19:11 ` Tom Tromey [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87r3bpjaxo.fsf@tromey.com \
--to=tom@tromey.com \
--cc=gdb-patches@sourceware.org \
--cc=manish@mozilla.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox