From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 112830 invoked by alias); 22 Jun 2016 19:11:52 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 112814 invoked by uid 89); 22 Jun 2016 19:11:51 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.4 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_NONE,SPF_PASS autolearn=ham version=3.3.2 spammy=Hx-languages-length:909 X-HELO: gproxy5-pub.mail.unifiedlayer.com Received: from gproxy5-pub.mail.unifiedlayer.com (HELO gproxy5-pub.mail.unifiedlayer.com) (67.222.38.55) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with SMTP; Wed, 22 Jun 2016 19:11:39 +0000 Received: (qmail 10278 invoked by uid 0); 22 Jun 2016 19:11:38 -0000 Received: from unknown (HELO cmgw3) (10.0.90.84) by gproxy5.mail.unifiedlayer.com with SMTP; 22 Jun 2016 19:11:38 -0000 Received: from box522.bluehost.com ([74.220.219.122]) by cmgw3 with id 9vBa1t01H2f2jeq01vBdgE; Wed, 22 Jun 2016 13:11:37 -0600 X-Authority-Analysis: v=2.1 cv=KpLehwmN c=1 sm=1 tr=0 a=GsOEXm/OWkKvwdLVJsfwcA==:117 a=GsOEXm/OWkKvwdLVJsfwcA==:17 a=L9H7d07YOLsA:10 a=9cW_t1CCXrUA:10 a=s5jvgZ67dGcA:10 a=PnD2wP_eR3oA:10 a=7XZj0uCbPdcA:10 a=pD_ry4oyNxEA:10 a=BzObnAOqAAAA:8 a=CCpqsmhAAAAA:8 a=DvnZwA91Jq-IFc60DFsA:9 a=PuSIgb6VMkSJ0_1bSHE4:22 a=ul9cdbp4aOFLsgKbc677:22 Received: from [75.171.172.174] (port=45114 helo=pokyo) by box522.bluehost.com with esmtpsa (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.86_2) (envelope-from ) id 1bFnYk-0004PZ-MB; Wed, 22 Jun 2016 13:11:34 -0600 From: Tom Tromey To: Manish Goregaokar Cc: gdb-patches@sourceware.org, Tom Tromey Subject: Re: [PATCH 2/2][PR gdb/20239] Add tests for printing of NonZero-optimized enums in Rust References: Date: Wed, 22 Jun 2016 19:11:00 -0000 In-Reply-To: (Manish Goregaokar's message of "Tue, 21 Jun 2016 15:11:52 +0530") Message-ID: <87r3bpjaxo.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.0.95 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Identified-User: {36111:box522.bluehost.com:elynrobi:tromey.com} {sentby:smtp auth 75.171.172.174 authed with tom+tromey.com} X-Exim-ID: 1bFnYk-0004PZ-MB X-Source-Sender: (pokyo) [75.171.172.174]:45114 X-Source-Auth: tom+tromey.com X-Email-Count: 0 X-Source-Cap: ZWx5bnJvYmk7ZWx5bnJvYmk7Ym94NTIyLmJsdWVob3N0LmNvbQ== X-SW-Source: 2016-06/txt/msg00373.txt.bz2 >>>>> "Manish" == Manish Goregaokar writes: Manish> Continuing discussion from Manish> https://sourceware.org/bugzilla/show_bug.cgi?id=20239, I'm not sure if Manish> it's worth it to have a test that inspects the entire output, since Manish> the internals of the String type may change in the future. Did you Manish> mean something else? Actually it just wasn't clear to me if the test case in question was "as complicated" as the code inspiring the original report. But it probably doesn't matter. Manish> gdb/testsuite/ChangeLog: Manish> 2016-06-21 Manish Goregaokar Manish> PR gdb/20239 Manish> * gdb.rust/simple.rs: Add more tests for printing NonZero enums. Manish> * gdb.rust/simple.exp: Add test expectations for new NonZero tests. Thank you. This patch is ok. Tom