From: Sergio Durigan Junior <sergiodj@redhat.com>
To: Pedro Alves <palves@redhat.com>
Cc: GDB Patches <gdb-patches@sourceware.org>
Subject: Re: [PATCH] Fix PR remote/21852: Remote run without specifying a local binary crashes GDB
Date: Wed, 23 Aug 2017 21:29:00 -0000 [thread overview]
Message-ID: <87r2w2vuqn.fsf@redhat.com> (raw)
In-Reply-To: <5f5fd8bf-2a6a-f98e-71e3-3c3ff4c03c8e@redhat.com> (Pedro Alves's message of "Wed, 23 Aug 2017 20:32:14 +0100")
On Wednesday, August 23 2017, Pedro Alves wrote:
> On 08/23/2017 06:36 PM, Sergio Durigan Junior wrote:
>
>> A testcase is provided. Regtested on buildbot.
>
> Looks good to me. A question below.
>
>> gdb/ChangeLog:
>> 2017-08-23 Pedro Alvex <palves@redhat.com>
>
> Love my new name, thanks. :-)
Sigh. Sorry, fixed.
>> + # Let's start gdbserver in extended-remote mode now.
>> + set res [gdbserver_start "--multi" ""]
>> + set gdbserver_protocol [lindex $res 0]
>> + if { [string first "extended-" $gdbserver_protocol] != 0} {
>> + set gdbserver_protocol "extended-$gdbserver_protocol"
>> + }
>> + set gdbserver_gdbport [lindex $res 1]
>> + set use_gdb_stub 0
>
> I guess this can't use gdbserver_start_extended because that
> somehow assumes you're starting with a binary? Can you add
> a comment?
Exactly. And sure, I added a comment.
Pushed:
87215ad1651ca3094d813eae06233fd7259b37e5
Thanks,
--
Sergio
GPG key ID: 237A 54B1 0287 28BF 00EF 31F4 D0EB 7628 65FC 5E36
Please send encrypted e-mail if possible
http://sergiodj.net/
prev parent reply other threads:[~2017-08-23 21:29 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-08-22 14:05 Sergio Durigan Junior
2017-08-22 18:09 ` Pedro Alves
2017-08-22 22:56 ` Sergio Durigan Junior
2017-08-22 23:19 ` Pedro Alves
2017-08-23 17:36 ` Sergio Durigan Junior
2017-08-23 19:32 ` Pedro Alves
2017-08-23 21:29 ` Sergio Durigan Junior [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87r2w2vuqn.fsf@redhat.com \
--to=sergiodj@redhat.com \
--cc=gdb-patches@sourceware.org \
--cc=palves@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox