From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 86714 invoked by alias); 23 Aug 2017 21:29:09 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 86423 invoked by uid 89); 23 Aug 2017 21:29:08 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-6.9 required=5.0 tests=BAYES_00,GIT_PATCH_1,RP_MATCHES_RCVD,SPF_HELO_PASS autolearn=ham version=3.3.2 spammy=Love X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Wed, 23 Aug 2017 21:29:06 +0000 Received: from smtp.corp.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id AC6E8883BD for ; Wed, 23 Aug 2017 21:29:05 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mx1.redhat.com AC6E8883BD Authentication-Results: ext-mx02.extmail.prod.ext.phx2.redhat.com; dmarc=none (p=none dis=none) header.from=redhat.com Authentication-Results: ext-mx02.extmail.prod.ext.phx2.redhat.com; spf=fail smtp.mailfrom=sergiodj@redhat.com Received: from localhost (unused-10-15-17-193.yyz.redhat.com [10.15.17.193]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 845126047C; Wed, 23 Aug 2017 21:29:05 +0000 (UTC) From: Sergio Durigan Junior To: Pedro Alves Cc: GDB Patches Subject: Re: [PATCH] Fix PR remote/21852: Remote run without specifying a local binary crashes GDB References: <3ef5d58f-6d27-8f07-b45d-db7f883837a4@redhat.com> <20170823173608.17654-1-sergiodj@redhat.com> <5f5fd8bf-2a6a-f98e-71e3-3c3ff4c03c8e@redhat.com> Date: Wed, 23 Aug 2017 21:29:00 -0000 In-Reply-To: <5f5fd8bf-2a6a-f98e-71e3-3c3ff4c03c8e@redhat.com> (Pedro Alves's message of "Wed, 23 Aug 2017 20:32:14 +0100") Message-ID: <87r2w2vuqn.fsf@redhat.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-IsSubscribed: yes X-SW-Source: 2017-08/txt/msg00455.txt.bz2 On Wednesday, August 23 2017, Pedro Alves wrote: > On 08/23/2017 06:36 PM, Sergio Durigan Junior wrote: > >> A testcase is provided. Regtested on buildbot. > > Looks good to me. A question below. > >> gdb/ChangeLog: >> 2017-08-23 Pedro Alvex > > Love my new name, thanks. :-) Sigh. Sorry, fixed. >> + # Let's start gdbserver in extended-remote mode now. >> + set res [gdbserver_start "--multi" ""] >> + set gdbserver_protocol [lindex $res 0] >> + if { [string first "extended-" $gdbserver_protocol] != 0} { >> + set gdbserver_protocol "extended-$gdbserver_protocol" >> + } >> + set gdbserver_gdbport [lindex $res 1] >> + set use_gdb_stub 0 > > I guess this can't use gdbserver_start_extended because that > somehow assumes you're starting with a binary? Can you add > a comment? Exactly. And sure, I added a comment. Pushed: 87215ad1651ca3094d813eae06233fd7259b37e5 Thanks, -- Sergio GPG key ID: 237A 54B1 0287 28BF 00EF 31F4 D0EB 7628 65FC 5E36 Please send encrypted e-mail if possible http://sergiodj.net/