From: Tom Tromey <tom@tromey.com>
To: Simon Marchi <simon.marchi@ericsson.com>
Cc: Tom Tromey <tom@tromey.com>, <gdb-patches@sourceware.org>
Subject: Re: [PATCH] Replace psymbol_allocation_list with std::vector
Date: Sat, 14 Oct 2017 04:50:00 -0000 [thread overview]
Message-ID: <87r2u6tjtc.fsf@tromey.com> (raw)
In-Reply-To: <112a72c3-bc3e-1c2a-c108-a4ff19146902@ericsson.com> (Simon Marchi's message of "Fri, 13 Oct 2017 23:01:55 -0400")
>>>>> "Simon" == Simon Marchi <simon.marchi@ericsson.com> writes:
Simon> It can't really hurt. Since those lists are not expected to change after that
Simon> point, it seems useless to keep the extra unused memory in the vector. I would
Simon> apply this fixup to my patch, WDYT?
It seems reasonable, thanks. I suppose sometimes it could be slower.
But on the other hand it seems likely to regularly waste memory in the
current state.
Tom
next prev parent reply other threads:[~2017-10-14 4:50 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-10-13 13:58 Simon Marchi
2017-10-13 21:03 ` Tom Tromey
2017-10-13 21:10 ` Tom Tromey
2017-10-14 3:02 ` Simon Marchi
2017-10-14 4:50 ` Tom Tromey [this message]
2017-10-14 12:09 ` Simon Marchi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87r2u6tjtc.fsf@tromey.com \
--to=tom@tromey.com \
--cc=gdb-patches@sourceware.org \
--cc=simon.marchi@ericsson.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox