From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 9782 invoked by alias); 14 Oct 2017 04:50:00 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 9767 invoked by uid 89); 14 Oct 2017 04:50:00 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.7 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_NONE,RCVD_IN_SORBS_SPAM,SPF_PASS autolearn=no version=3.3.2 spammy= X-HELO: gproxy6-pub.mail.unifiedlayer.com Received: from gproxy6-pub.mail.unifiedlayer.com (HELO gproxy6-pub.mail.unifiedlayer.com) (67.222.39.168) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Sat, 14 Oct 2017 04:49:59 +0000 Received: from cmgw2 (unknown [10.0.90.83]) by gproxy6.mail.unifiedlayer.com (Postfix) with ESMTP id F2CED1E07D2 for ; Fri, 13 Oct 2017 22:49:57 -0600 (MDT) Received: from box522.bluehost.com ([74.220.219.122]) by cmgw2 with id MGpu1w00G2f2jeq01GpxP7; Fri, 13 Oct 2017 22:49:57 -0600 X-Authority-Analysis: v=2.2 cv=dZfw5Tfe c=1 sm=1 tr=0 a=GsOEXm/OWkKvwdLVJsfwcA==:117 a=GsOEXm/OWkKvwdLVJsfwcA==:17 a=02M-m0pO-4AA:10 a=0FD05c-RAAAA:8 a=yCWOGq0EtcXY-TJhuN0A:9 a=l1rpMCqCXRGZwUSuRcM3:22 Received: from 184-96-33-178.hlrn.qwest.net ([184.96.33.178]:35590 helo=bapiya) by box522.bluehost.com with esmtpsa (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.87) (envelope-from ) id 1e3EOY-000KZo-B6; Fri, 13 Oct 2017 22:49:54 -0600 From: Tom Tromey To: Simon Marchi Cc: Tom Tromey , Subject: Re: [PATCH] Replace psymbol_allocation_list with std::vector References: <1507903080-10737-1-git-send-email-simon.marchi@ericsson.com> <87k1zypxdk.fsf@tromey.com> <112a72c3-bc3e-1c2a-c108-a4ff19146902@ericsson.com> Date: Sat, 14 Oct 2017 04:50:00 -0000 In-Reply-To: <112a72c3-bc3e-1c2a-c108-a4ff19146902@ericsson.com> (Simon Marchi's message of "Fri, 13 Oct 2017 23:01:55 -0400") Message-ID: <87r2u6tjtc.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.0.60 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-BWhitelist: no X-Exim-ID: 1e3EOY-000KZo-B6 X-Source-Sender: 184-96-33-178.hlrn.qwest.net (bapiya) [184.96.33.178]:35590 X-Source-Auth: tom+tromey.com X-Email-Count: 4 X-Source-Cap: ZWx5bnJvYmk7ZWx5bnJvYmk7Ym94NTIyLmJsdWVob3N0LmNvbQ== X-Local-Domain: yes X-SW-Source: 2017-10/txt/msg00387.txt.bz2 >>>>> "Simon" == Simon Marchi writes: Simon> It can't really hurt. Since those lists are not expected to change after that Simon> point, it seems useless to keep the extra unused memory in the vector. I would Simon> apply this fixup to my patch, WDYT? It seems reasonable, thanks. I suppose sometimes it could be slower. But on the other hand it seems likely to regularly waste memory in the current state. Tom