From: Tom Tromey <tom@tromey.com>
To: Simon Marchi <simon.marchi@polymtl.ca>
Cc: Tom Tromey <tom@tromey.com>, gdb-patches@sourceware.org
Subject: Re: [RFA] Remove a cleanup from call_function_by_hand_dummy
Date: Sat, 17 Feb 2018 20:47:00 -0000 [thread overview]
Message-ID: <87r2pj4a3x.fsf@tromey.com> (raw)
In-Reply-To: <bc14a7c64b3f1d90bdea0d14734bed23@polymtl.ca> (Simon Marchi's message of "Sat, 17 Feb 2018 14:23:43 -0500")
>>>>> "Simon" == Simon Marchi <simon.marchi@polymtl.ca> writes:
Simon> This should probably be resize instead of reserve. When you call
Simon> reserve, it doesn't change the actual length of the vector. You could
Simon> then use a def_vector to avoid unneeded zero-initialization by the
Simon> resize operation.
I think I get these mixed up 100% of the time :(
What's worse is I read the docs and I guess misunderstood them again.
Maybe I should avoid this entirely by using std::copy or something like
that.
Tom
next prev parent reply other threads:[~2018-02-17 20:47 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-02-17 16:11 Tom Tromey
2018-02-17 19:23 ` Simon Marchi
2018-02-17 20:47 ` Tom Tromey [this message]
2018-02-21 3:54 ` Tom Tromey
2018-02-21 13:04 ` Simon Marchi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87r2pj4a3x.fsf@tromey.com \
--to=tom@tromey.com \
--cc=gdb-patches@sourceware.org \
--cc=simon.marchi@polymtl.ca \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox