Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Tom Tromey <tom@tromey.com>
To: Andrew Burgess <andrew.burgess@embecosm.com>
Cc: gdb-patches@sourceware.org
Subject: Re: [PATCH 1/2] gdb: Respect field width and alignment for 'fmt' fields in CLI output
Date: Tue, 20 Nov 2018 22:17:00 -0000	[thread overview]
Message-ID: <87r2ffo0lj.fsf@tromey.com> (raw)
In-Reply-To: <7ff8ea3a0c985be7d9ea83746d471683347520e0.1542745482.git.andrew.burgess@embecosm.com>	(Andrew Burgess's message of "Tue, 20 Nov 2018 20:30:05 +0000")

>>>>> "Andrew" == Andrew Burgess <andrew.burgess@embecosm.com> writes:

Andrew> This patch has been tested on x86-64/Linux with no regressions,
Andrew> however, the testsuite doesn't always spot broken output formatting or
Andrew> alignment.  I have also audited all uses of 'fmt' fields that I could
Andrew> find, and I don't think there are any other places that specifically
Andrew> try to work around the lack of width/alignment, however, I could have
Andrew> missed something.

Thanks for the patch.

Andrew> -  vfprintf_filtered (m_streams.back (), format, args);
Andrew> +  string_file stb;
Andrew> +  stb.vprintf (format, args);

I think just using string_vprintf directly is simpler here.
This is ok with that change.

Tom


      reply	other threads:[~2018-11-20 22:17 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-11-20 20:30 [PATCH 0/2] Changes to cli-out.c for field alignment and formatting Andrew Burgess
2018-11-20 20:30 ` [PATCH 2/2] gdb: Use string_printf to format int fields instead of a fixed size buffer Andrew Burgess
2018-11-20 22:18   ` Tom Tromey
2018-11-20 20:30 ` [PATCH 1/2] gdb: Respect field width and alignment for 'fmt' fields in CLI output Andrew Burgess
2018-11-20 22:17   ` Tom Tromey [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87r2ffo0lj.fsf@tromey.com \
    --to=tom@tromey.com \
    --cc=andrew.burgess@embecosm.com \
    --cc=gdb-patches@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox