From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 56121 invoked by alias); 20 Nov 2018 22:17:32 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 56111 invoked by uid 89); 20 Nov 2018 22:17:32 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-2.9 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_NONE,SPF_HELO_PASS autolearn=ham version=3.3.2 spammy=D*embecosm.com, andrewburgessembecosmcom, andrew.burgess@embecosm.com, Hx-languages-length:815 X-HELO: gateway36.websitewelcome.com Received: from gateway36.websitewelcome.com (HELO gateway36.websitewelcome.com) (192.185.198.13) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Tue, 20 Nov 2018 22:17:30 +0000 Received: from cm16.websitewelcome.com (cm16.websitewelcome.com [100.42.49.19]) by gateway36.websitewelcome.com (Postfix) with ESMTP id 1111440112DA6 for ; Tue, 20 Nov 2018 15:26:36 -0600 (CST) Received: from box5379.bluehost.com ([162.241.216.53]) by cmsmtp with SMTP id PEKngHTnPaSeyPEKngVUbT; Tue, 20 Nov 2018 16:17:29 -0600 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=tromey.com; s=default; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date: References:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=bO96BoU5Ysm9CFJLCXV1tlOptorSmFKvE6OwsSuis4U=; b=m0/8VGRo96pDixULWPp9IeYc0I GZW92Wy7oKUhbo1cgTG9tWl/IOkeP6hURaShuDEgzIC9Z0xPKdqM/gMeAr8/PeS3PvIbZwQN2hZgy NLrK1KJODM6nHwl0p0hi4oIec; Received: from 97-122-190-66.hlrn.qwest.net ([97.122.190.66]:50760 helo=pokyo) by box5379.bluehost.com with esmtpsa (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.91) (envelope-from ) id 1gPEKm-002kHz-Ts; Tue, 20 Nov 2018 16:17:29 -0600 From: Tom Tromey To: Andrew Burgess Cc: gdb-patches@sourceware.org Subject: Re: [PATCH 1/2] gdb: Respect field width and alignment for 'fmt' fields in CLI output References: <7ff8ea3a0c985be7d9ea83746d471683347520e0.1542745482.git.andrew.burgess@embecosm.com> Date: Tue, 20 Nov 2018 22:17:00 -0000 In-Reply-To: <7ff8ea3a0c985be7d9ea83746d471683347520e0.1542745482.git.andrew.burgess@embecosm.com> (Andrew Burgess's message of "Tue, 20 Nov 2018 20:30:05 +0000") Message-ID: <87r2ffo0lj.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.1.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-SW-Source: 2018-11/txt/msg00345.txt.bz2 >>>>> "Andrew" == Andrew Burgess writes: Andrew> This patch has been tested on x86-64/Linux with no regressions, Andrew> however, the testsuite doesn't always spot broken output formatting or Andrew> alignment. I have also audited all uses of 'fmt' fields that I could Andrew> find, and I don't think there are any other places that specifically Andrew> try to work around the lack of width/alignment, however, I could have Andrew> missed something. Thanks for the patch. Andrew> - vfprintf_filtered (m_streams.back (), format, args); Andrew> + string_file stb; Andrew> + stb.vprintf (format, args); I think just using string_vprintf directly is simpler here. This is ok with that change. Tom