From: Tom Tromey <tom@tromey.com>
To: Simon Marchi <simon.marchi@efficios.com>
Cc: gdb-patches@sourceware.org
Subject: Re: [PATCH 0/4] Remove some uses of iterate_over_inferiors
Date: Thu, 16 Jan 2020 16:23:00 -0000 [thread overview]
Message-ID: <87r1zzs8qz.fsf@tromey.com> (raw)
In-Reply-To: <20200115191222.28208-1-simon.marchi@efficios.com> (Simon Marchi's message of "Wed, 15 Jan 2020 14:12:18 -0500")
>>>>> "Simon" == Simon Marchi <simon.marchi@efficios.com> writes:
Simon> Today, it's very easy to iterate over inferiors using a range-based for
Simon> loop combined with all_inferiors. I think it gives simpler and easier
Simon> to understand code than iterate_over_inferiors, which uses a void
Simon> pointer to pass data from the caller. I noticed that there were very
Simon> few uses of iterate_over_inferiors left, so I think we could convert
Simon> them to range-based for loop and get rid of it.
I sent some patches like this a while back, but never got around to
finishing the series, so I never checked them in.
https://sourceware.org/ml/gdb-patches/2019-09/msg00381.html
These all look fine to me and I think you should push them.
You wrote one patch I didn't (and I think you did more in mi-main.c
too?), and I wrote one you didn't; I'll resurrect that one and push it
once yours are in:
https://sourceware.org/ml/gdb-patches/2019-09/msg00383.html
Tom
next prev parent reply other threads:[~2020-01-16 15:48 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-01-15 19:12 Simon Marchi
2020-01-15 19:12 ` [PATCH 2/4] gdb: remove use of iterate_over_inferiors in mi/mi-interp.c Simon Marchi
2020-01-16 11:29 ` Aktemur, Tankut Baris
2020-01-16 15:31 ` Simon Marchi
2020-01-17 7:52 ` Aktemur, Tankut Baris
2020-01-17 15:14 ` Simon Marchi
2020-01-15 19:12 ` [PATCH 4/4] gdb: remove uses of iterate_over_inferiors in top.c Simon Marchi
2020-01-15 19:18 ` [PATCH 1/4] gdb: remove use of iterate_over_inferiors in py-inferior.c Simon Marchi
2020-01-15 19:50 ` [PATCH 3/4] gdb: remove uses of iterate_over_inferiors in mi/mi-main.c Simon Marchi
2020-01-16 16:23 ` Tom Tromey [this message]
2020-01-16 22:46 ` [PATCH 0/4] Remove some uses of iterate_over_inferiors Simon Marchi
-- strict thread matches above, loose matches on Subject: below --
2019-09-19 21:28 Tom Tromey
2019-09-20 2:16 ` Simon Marchi
2019-09-20 14:02 ` Tom Tromey
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87r1zzs8qz.fsf@tromey.com \
--to=tom@tromey.com \
--cc=gdb-patches@sourceware.org \
--cc=simon.marchi@efficios.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox