From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 29975 invoked by alias); 16 Jan 2020 15:48:42 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 29810 invoked by uid 89); 16 Jan 2020 15:48:31 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-8.6 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_NONE,SPF_HELO_PASS autolearn=ham version=3.3.1 spammy=finishing, yours X-HELO: gateway36.websitewelcome.com Received: from gateway36.websitewelcome.com (HELO gateway36.websitewelcome.com) (192.185.188.18) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Thu, 16 Jan 2020 15:48:21 +0000 Received: from cm17.websitewelcome.com (cm17.websitewelcome.com [100.42.49.20]) by gateway36.websitewelcome.com (Postfix) with ESMTP id 5AD73400C8FAA for ; Thu, 16 Jan 2020 09:00:37 -0600 (CST) Received: from box5379.bluehost.com ([162.241.216.53]) by cmsmtp with SMTP id s7NNimLcwqNtvs7NNiO4oX; Thu, 16 Jan 2020 09:48:05 -0600 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=tromey.com; s=default; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date: References:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=ozdC8uLUVJztLlFEb+mm/8MJYCHFZmYFKY8bRi3XwLs=; b=b4QG+7TwQWn759abb4y+SYgTaS rDXzQ60xOeTYzotyJ1msREWQ8JsZg+Drvd+MwioQyQiXmyuiOKsuSKxHHt2tzkj/hpoL8Vc8Sul1c DcfYjfKE1opcmxymN2QlDCnpp; Received: from 75-166-123-50.hlrn.qwest.net ([75.166.123.50]:51270 helo=murgatroyd) by box5379.bluehost.com with esmtpsa (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.92) (envelope-from ) id 1is7NN-002TNS-CU; Thu, 16 Jan 2020 08:48:05 -0700 From: Tom Tromey To: Simon Marchi Cc: gdb-patches@sourceware.org Subject: Re: [PATCH 0/4] Remove some uses of iterate_over_inferiors References: <20200115191222.28208-1-simon.marchi@efficios.com> Date: Thu, 16 Jan 2020 16:23:00 -0000 In-Reply-To: <20200115191222.28208-1-simon.marchi@efficios.com> (Simon Marchi's message of "Wed, 15 Jan 2020 14:12:18 -0500") Message-ID: <87r1zzs8qz.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.3 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-SW-Source: 2020-01/txt/msg00453.txt.bz2 >>>>> "Simon" == Simon Marchi writes: Simon> Today, it's very easy to iterate over inferiors using a range-based for Simon> loop combined with all_inferiors. I think it gives simpler and easier Simon> to understand code than iterate_over_inferiors, which uses a void Simon> pointer to pass data from the caller. I noticed that there were very Simon> few uses of iterate_over_inferiors left, so I think we could convert Simon> them to range-based for loop and get rid of it. I sent some patches like this a while back, but never got around to finishing the series, so I never checked them in. https://sourceware.org/ml/gdb-patches/2019-09/msg00381.html These all look fine to me and I think you should push them. You wrote one patch I didn't (and I think you did more in mi-main.c too?), and I wrote one you didn't; I'll resurrect that one and push it once yours are in: https://sourceware.org/ml/gdb-patches/2019-09/msg00383.html Tom