From: Tom Tromey <tom@tromey.com>
To: Tom de Vries <tdevries@suse.de>
Cc: gdb-patches@sourceware.org
Subject: Re: [committed][gdb/symtab] Fix segfault in process_psymtab_comp_unit
Date: Thu, 27 May 2021 10:34:41 -0600 [thread overview]
Message-ID: <87r1hst9su.fsf@tromey.com> (raw)
In-Reply-To: <20210527132729.GA3386@delia> (Tom de Vries's message of "Thu, 27 May 2021 15:27:30 +0200")
>>>>> "Tom" == Tom de Vries <tdevries@suse.de> writes:
Tom> + if (reader.comp_unit_die == nullptr)
Tom> + return;
I think it's more normal to test the 'dummy_p' member.
There may be some other way in use as well though... probably this could
be cleaned up somehow.
Tom
prev parent reply other threads:[~2021-05-27 16:34 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-05-27 13:27 Tom de Vries
2021-05-27 16:34 ` Tom Tromey [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87r1hst9su.fsf@tromey.com \
--to=tom@tromey.com \
--cc=gdb-patches@sourceware.org \
--cc=tdevries@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox