From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id o6JIJCjKr2D/QQAAWB0awg (envelope-from ) for ; Thu, 27 May 2021 12:34:48 -0400 Received: by simark.ca (Postfix, from userid 112) id 85CC31F11C; Thu, 27 May 2021 12:34:48 -0400 (EDT) X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-0.9 required=5.0 tests=DKIM_SIGNED, MAILING_LIST_MULTI,T_DKIM_INVALID,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.2 Received: from sourceware.org (server2.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 46B551E01F for ; Thu, 27 May 2021 12:34:47 -0400 (EDT) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 91ECC3959E45; Thu, 27 May 2021 16:34:46 +0000 (GMT) Received: from gateway32.websitewelcome.com (gateway32.websitewelcome.com [192.185.145.187]) by sourceware.org (Postfix) with ESMTPS id 6C1D739574D5 for ; Thu, 27 May 2021 16:34:43 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org 6C1D739574D5 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=tromey.com Authentication-Results: sourceware.org; spf=fail smtp.mailfrom=tom@tromey.com Received: from cm16.websitewelcome.com (cm16.websitewelcome.com [100.42.49.19]) by gateway32.websitewelcome.com (Postfix) with ESMTP id CCDF3305A for ; Thu, 27 May 2021 11:34:42 -0500 (CDT) Received: from box5379.bluehost.com ([162.241.216.53]) by cmsmtp with SMTP id mIy2l0dqxFRe9mIy2lub2V; Thu, 27 May 2021 11:34:42 -0500 X-Authority-Reason: nr=8 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=tromey.com; s=default; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date:References :Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=OEg3wzGKoB9WTe1P3QBk4fTSwRP6GEtPZWzh30xOqdk=; b=SD26Ti61hT+xsCcyCkgoXztm1i DSGwbl7Uqrrr45+RjmLEYhuU+Uu42awV59o+d/nOwPOcj2NL4P4nNDrhq2reaibxMo5iiRE2DFOJR mcbYOiu9GHU4d71O7wwaFCAwy; Received: from 75-166-146-111.hlrn.qwest.net ([75.166.146.111]:54856 helo=murgatroyd) by box5379.bluehost.com with esmtpsa (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1lmIy2-000Bmt-D3; Thu, 27 May 2021 10:34:42 -0600 From: Tom Tromey To: Tom de Vries Subject: Re: [committed][gdb/symtab] Fix segfault in process_psymtab_comp_unit References: <20210527132729.GA3386@delia> X-Attribution: Tom Date: Thu, 27 May 2021 10:34:41 -0600 In-Reply-To: <20210527132729.GA3386@delia> (Tom de Vries's message of "Thu, 27 May 2021 15:27:30 +0200") Message-ID: <87r1hst9su.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - box5379.bluehost.com X-AntiAbuse: Original Domain - sourceware.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - tromey.com X-BWhitelist: no X-Source-IP: 75.166.146.111 X-Source-L: No X-Exim-ID: 1lmIy2-000Bmt-D3 X-Source: X-Source-Args: X-Source-Dir: X-Source-Sender: 75-166-146-111.hlrn.qwest.net (murgatroyd) [75.166.146.111]:54856 X-Source-Auth: tom+tromey.com X-Email-Count: 2 X-Source-Cap: ZWx5bnJvYmk7ZWx5bnJvYmk7Ym94NTM3OS5ibHVlaG9zdC5jb20= X-Local-Domain: yes X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: gdb-patches@sourceware.org Errors-To: gdb-patches-bounces@sourceware.org Sender: "Gdb-patches" >>>>> "Tom" == Tom de Vries writes: Tom> + if (reader.comp_unit_die == nullptr) Tom> + return; I think it's more normal to test the 'dummy_p' member. There may be some other way in use as well though... probably this could be cleaned up somehow. Tom