[PATCH][gdb/tdep] Declare score-*-* target obsolete

[PATCH][gdb/tdep] Declare score-*-* target obsolete

[Tom de Vries via Gdb-patches]

Hi,

I tried out the script gdb/gdb_mbuild.sh, and ran into:
...
score-elf ...
... configure --target=score-elf
... make score-elf
... run score-elf
score-elf: gdb dumped core
Terminated
...

Gdb runs into this internal error in initialize_current_architecture:
...
  if (! gdbarch_update_p (info))
    internal_error (__FILE__, __LINE__,
                    _("initialize_current_architecture: Selection of "
                      "initial architecture failed"));
...

The call to gdbarch_update_p fails because commit 575b4c298a6 ("gdb: Remove
support for S+core") removed support for the architecture.

Fix this by adding score-*-* to the list of obsolete targets in
gdb/configure.tgt, such that we're no longer able to build the configuration:
...
*** Configuration score-unknown-elf is obsolete.
*** Support has been REMOVED.
make: *** [Makefile:12806: configure-gdb] Error 1
...

Also remove the related line from the "Target Instruction Set Architectures"
list in gdb/MAINTAINERS, such that gdb/gdb_mbuild.sh no longer tries to build
it.

Any comments?

Thanks,
- Tom

[gdb/tdep] Declare score-*-* target obsolete

---
 gdb/MAINTAINERS   | 1 -
 gdb/configure.tgt | 1 +
 2 files changed, 1 insertion(+), 1 deletion(-)

diff --git a/gdb/MAINTAINERS b/gdb/MAINTAINERS
index dcc3e038408..ed2b6f51f81 100644
--- a/gdb/MAINTAINERS
+++ b/gdb/MAINTAINERS
@@ -325,7 +325,6 @@ the native maintainer when resolving ABI issues.
 	s390		--target=s390-linux-gnu ,-Werror
 			Andreas Arnez		arnez@linux.ibm.com
 
-	score		--target=score-elf
 	sh		--target=sh-elf ,-Werror
 
 	sparc		--target=sparcv9-solaris2.11 ,-Werror
diff --git a/gdb/configure.tgt b/gdb/configure.tgt
index 0705ccf32b8..e84e222ba0d 100644
--- a/gdb/configure.tgt
+++ b/gdb/configure.tgt
@@ -26,6 +26,7 @@ case $targ in
  m68*-*-os68k* | \
  mips*-*-pe | \
  rs6000-*-lynxos* | \
+ score-*-* | \
  sh*-*-pe | \
  hppa*-*-hpux* | \
  ia64-*-hpux* | \

Re: [PATCH][gdb/tdep] Declare score-*-* target obsolete

[Tom Tromey]

>>>>> "Tom" == Tom de Vries via Gdb-patches <gdb-patches@sourceware.org> writes:

Tom> The call to gdbarch_update_p fails because commit 575b4c298a6 ("gdb: Remove
Tom> support for S+core") removed support for the architecture.

Tom> Fix this by adding score-*-* to the list of obsolete targets in
Tom> gdb/configure.tgt, such that we're no longer able to build the configuration:
Tom> ...
Tom> *** Configuration score-unknown-elf is obsolete.
Tom> *** Support has been REMOVED.
Tom> make: *** [Makefile:12806: configure-gdb] Error 1
Tom> ...

Tom> Also remove the related line from the "Target Instruction Set Architectures"
Tom> list in gdb/MAINTAINERS, such that gdb/gdb_mbuild.sh no longer tries to build
Tom> it.

Tom> Any comments?

Looks good, thanks.

Tom